[PATCH] hw-breakpoints: let modify_user_hw

mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed

* [PATCH] hw-breakpoints: let modify_user_hw_breakpoint return an int
@ 2009-12-14  9:24 Heiko Carstens
  2009-12-14  9:49 ` [tip:perf/urgent] hw-breakpoints: Let modify_user_hw_breakpoint() " tip-bot for Heiko Carstens
  0 siblings, 1 reply; 5+ messages in thread
From: Heiko Carstens @ 2009-12-14  9:24 UTC (permalink / raw)
  To: Frederic Weisbecker, Ingo Molnar; +Cc: linux-kernel

From: Heiko Carstens <heiko.carstens@de.ibm.com>

Let modify_user_hw_breakpoint return an int to avoid hundreds of compile
warnings like this one:

include/linux/hw_breakpoint.h: In function 'modify_user_hw_breakpoint':
include/linux/hw_breakpoint.h:96: warning: return makes integer from pointer without a cast

Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
---
 include/linux/hw_breakpoint.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6/include/linux/hw_breakpoint.h
===================================================================
--- linux-2.6.orig/include/linux/hw_breakpoint.h
+++ linux-2.6/include/linux/hw_breakpoint.h
@@ -93,7 +93,7 @@ register_user_hw_breakpoint(struct perf_
 			    struct task_struct *tsk)	{ return NULL; }
 static inline int
 modify_user_hw_breakpoint(struct perf_event *bp,
-			  struct perf_event_attr *attr)	{ return NULL; }
+			  struct perf_event_attr *attr)	{ return 0; }
 static inline struct perf_event *
 register_wide_hw_breakpoint_cpu(struct perf_event_attr *attr,
 				perf_overflow_handler_t	 triggered,

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [tip:perf/urgent] hw-breakpoints: Let modify_user_hw_breakpoint() return an int
  2009-12-14  9:24 [PATCH] hw-breakpoints: let modify_user_hw_breakpoint return an int Heiko Carstens
@ 2009-12-14  9:49 ` tip-bot for Heiko Carstens
  2009-12-14 10:37   ` Frederic Weisbecker
  2009-12-14 10:38   ` Stephen Rothwell
  0 siblings, 2 replies; 5+ messages in thread
From: tip-bot for Heiko Carstens @ 2009-12-14  9:49 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: linux-kernel, hpa, mingo, fweisbec, heiko.carstens, tglx, mingo

Commit-ID:  4983ee49cf0393fd786891dd53af41146cf9f98b
Gitweb:     http://git.kernel.org/tip/4983ee49cf0393fd786891dd53af41146cf9f98b
Author:     Heiko Carstens <heiko.carstens@de.ibm.com>
AuthorDate: Mon, 14 Dec 2009 10:24:12 +0100
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Mon, 14 Dec 2009 10:42:57 +0100

hw-breakpoints: Let modify_user_hw_breakpoint() return an int

Let modify_user_hw_breakpoint return an int to avoid hundreds of
compile warnings like this one:

 include/linux/hw_breakpoint.h: In function 'modify_user_hw_breakpoint':
 include/linux/hw_breakpoint.h:96:
  warning: return makes integer from pointer without a cast

Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
LKML-Reference: <20091214092412.GA5242@osiris.boeblingen.de.ibm.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 include/linux/hw_breakpoint.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/hw_breakpoint.h b/include/linux/hw_breakpoint.h
index 41235c9..3f3ac2f 100644
--- a/include/linux/hw_breakpoint.h
+++ b/include/linux/hw_breakpoint.h
@@ -90,7 +90,7 @@ static inline struct arch_hw_breakpoint *counter_arch_bp(struct perf_event *bp)
 static inline struct perf_event *
 register_user_hw_breakpoint(struct perf_event_attr *attr,
 			    perf_overflow_handler_t triggered,
-			    struct task_struct *tsk)	{ return NULL; }
+			    struct task_struct *tsk)	{ return 0; }
 static inline int
 modify_user_hw_breakpoint(struct perf_event *bp,
 			  struct perf_event_attr *attr)	{ return -ENOSYS; }

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [tip:perf/urgent] hw-breakpoints: Let modify_user_hw_breakpoint() return an int
  2009-12-14  9:49 ` [tip:perf/urgent] hw-breakpoints: Let modify_user_hw_breakpoint() " tip-bot for Heiko Carstens
@ 2009-12-14 10:37   ` Frederic Weisbecker
  2009-12-14 10:38   ` Stephen Rothwell
  1 sibling, 0 replies; 5+ messages in thread
From: Frederic Weisbecker @ 2009-12-14 10:37 UTC (permalink / raw)
  To: mingo, hpa, linux-kernel, heiko.carstens, tglx, mingo; +Cc: linux-tip-commits

On Mon, Dec 14, 2009 at 09:49:44AM +0000, tip-bot for Heiko Carstens wrote:
> Commit-ID:  4983ee49cf0393fd786891dd53af41146cf9f98b
> Gitweb:     http://git.kernel.org/tip/4983ee49cf0393fd786891dd53af41146cf9f98b
> Author:     Heiko Carstens <heiko.carstens@de.ibm.com>
> AuthorDate: Mon, 14 Dec 2009 10:24:12 +0100
> Committer:  Ingo Molnar <mingo@elte.hu>
> CommitDate: Mon, 14 Dec 2009 10:42:57 +0100
> 
> hw-breakpoints: Let modify_user_hw_breakpoint() return an int
> 
> Let modify_user_hw_breakpoint return an int to avoid hundreds of
> compile warnings like this one:
> 
>  include/linux/hw_breakpoint.h: In function 'modify_user_hw_breakpoint':
>  include/linux/hw_breakpoint.h:96:
>   warning: return makes integer from pointer without a cast
> 
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> LKML-Reference: <20091214092412.GA5242@osiris.boeblingen.de.ibm.com>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>


Thanks!

I sent a patch for that but looks like it haven't made
its way :)

[PATCH] hw-breakpoints: Handle bad modify_user_hw_breakpoint off-case return value


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [tip:perf/urgent] hw-breakpoints: Let modify_user_hw_breakpoint() return an int
  2009-12-14  9:49 ` [tip:perf/urgent] hw-breakpoints: Let modify_user_hw_breakpoint() " tip-bot for Heiko Carstens
  2009-12-14 10:37   ` Frederic Weisbecker
@ 2009-12-14 10:38   ` Stephen Rothwell
  2009-12-14 10:54     ` Ingo Molnar
  1 sibling, 1 reply; 5+ messages in thread
From: Stephen Rothwell @ 2009-12-14 10:38 UTC (permalink / raw)
  To: mingo, hpa, linux-kernel, fweisbec, heiko.carstens, tglx, mingo
  Cc: tip-bot for Heiko Carstens, linux-tip-commits, linux-kernel, hpa,
	mingo, fweisbec, tglx, mingo

[-- Attachment #1: Type: text/plain, Size: 2057 bytes --]

Hi Ingo,

On Mon, 14 Dec 2009 09:49:44 GMT tip-bot for Heiko Carstens <heiko.carstens@de.ibm.com> wrote:
>
> Commit-ID:  4983ee49cf0393fd786891dd53af41146cf9f98b
> Gitweb:     http://git.kernel.org/tip/4983ee49cf0393fd786891dd53af41146cf9f98b
> Author:     Heiko Carstens <heiko.carstens@de.ibm.com>
> AuthorDate: Mon, 14 Dec 2009 10:24:12 +0100
> Committer:  Ingo Molnar <mingo@elte.hu>
> CommitDate: Mon, 14 Dec 2009 10:42:57 +0100
> 
> hw-breakpoints: Let modify_user_hw_breakpoint() return an int
> 
> Let modify_user_hw_breakpoint return an int to avoid hundreds of
> compile warnings like this one:
> 
>  include/linux/hw_breakpoint.h: In function 'modify_user_hw_breakpoint':
>  include/linux/hw_breakpoint.h:96:
>   warning: return makes integer from pointer without a cast
> 
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> LKML-Reference: <20091214092412.GA5242@osiris.boeblingen.de.ibm.com>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> ---
>  include/linux/hw_breakpoint.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/linux/hw_breakpoint.h b/include/linux/hw_breakpoint.h
> index 41235c9..3f3ac2f 100644
> --- a/include/linux/hw_breakpoint.h
> +++ b/include/linux/hw_breakpoint.h
> @@ -90,7 +90,7 @@ static inline struct arch_hw_breakpoint *counter_arch_bp(struct perf_event *bp)
>  static inline struct perf_event *
>  register_user_hw_breakpoint(struct perf_event_attr *attr,
>  			    perf_overflow_handler_t triggered,
> -			    struct task_struct *tsk)	{ return NULL; }
> +			    struct task_struct *tsk)	{ return 0; }
>  static inline int
>  modify_user_hw_breakpoint(struct perf_event *bp,
>  			  struct perf_event_attr *attr)	{ return -ENOSYS; }

This applied incorrectly ... it was a fix for modify_user_hw_breakpoint(),
but that fix has already bee applied to perf/urgent ...

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [tip:perf/urgent] hw-breakpoints: Let modify_user_hw_breakpoint() return an int
  2009-12-14 10:38   ` Stephen Rothwell
@ 2009-12-14 10:54     ` Ingo Molnar
  0 siblings, 0 replies; 5+ messages in thread
From: Ingo Molnar @ 2009-12-14 10:54 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: mingo, hpa, linux-kernel, fweisbec, heiko.carstens, tglx,
	linux-tip-commits


* Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi Ingo,
> 
> On Mon, 14 Dec 2009 09:49:44 GMT tip-bot for Heiko Carstens <heiko.carstens@de.ibm.com> wrote:
> >
> > Commit-ID:  4983ee49cf0393fd786891dd53af41146cf9f98b
> > Gitweb:     http://git.kernel.org/tip/4983ee49cf0393fd786891dd53af41146cf9f98b
> > Author:     Heiko Carstens <heiko.carstens@de.ibm.com>
> > AuthorDate: Mon, 14 Dec 2009 10:24:12 +0100
> > Committer:  Ingo Molnar <mingo@elte.hu>
> > CommitDate: Mon, 14 Dec 2009 10:42:57 +0100
> > 
> > hw-breakpoints: Let modify_user_hw_breakpoint() return an int
> > 
> > Let modify_user_hw_breakpoint return an int to avoid hundreds of
> > compile warnings like this one:
> > 
> >  include/linux/hw_breakpoint.h: In function 'modify_user_hw_breakpoint':
> >  include/linux/hw_breakpoint.h:96:
> >   warning: return makes integer from pointer without a cast
> > 
> > Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
> > Cc: Frederic Weisbecker <fweisbec@gmail.com>
> > LKML-Reference: <20091214092412.GA5242@osiris.boeblingen.de.ibm.com>
> > Signed-off-by: Ingo Molnar <mingo@elte.hu>
> > ---
> >  include/linux/hw_breakpoint.h |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/include/linux/hw_breakpoint.h b/include/linux/hw_breakpoint.h
> > index 41235c9..3f3ac2f 100644
> > --- a/include/linux/hw_breakpoint.h
> > +++ b/include/linux/hw_breakpoint.h
> > @@ -90,7 +90,7 @@ static inline struct arch_hw_breakpoint *counter_arch_bp(struct perf_event *bp)
> >  static inline struct perf_event *
> >  register_user_hw_breakpoint(struct perf_event_attr *attr,
> >  			    perf_overflow_handler_t triggered,
> > -			    struct task_struct *tsk)	{ return NULL; }
> > +			    struct task_struct *tsk)	{ return 0; }
> >  static inline int
> >  modify_user_hw_breakpoint(struct perf_event *bp,
> >  			  struct perf_event_attr *attr)	{ return -ENOSYS; }
> 
> This applied incorrectly ... it was a fix for modify_user_hw_breakpoint(), 
> but that fix has already bee applied to perf/urgent ...

yeah ... zapped it.

	Ingo

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2009-12-14 10:54 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-12-14  9:24 [PATCH] hw-breakpoints: let modify_user_hw_breakpoint return an int Heiko Carstens
2009-12-14  9:49 ` [tip:perf/urgent] hw-breakpoints: Let modify_user_hw_breakpoint() " tip-bot for Heiko Carstens
2009-12-14 10:37   ` Frederic Weisbecker
2009-12-14 10:38   ` Stephen Rothwell
2009-12-14 10:54     ` Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome