linux-next: ext3 tree build warning

linux-next: ext3 tree build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 871 bytes --]

Hi Jan,

Today's linux-next build (x86_64 allmodconfig) produced this warning:

fs/quota/dquot.c: In function 'dquot_alloc_inode':
fs/quota/dquot.c:1521: warning: passing argument 1 of 'mark_all_dquot_dirty' discards qualifiers from pointer target type
fs/quota/dquot.c:327: note: expected 'struct dquot **' but argument is of type 'struct dquot * const*'
fs/quota/dquot.c: In function 'dquot_free_inode':
fs/quota/dquot.c:1649: warning: passing argument 1 of 'mark_all_dquot_dirty' discards qualifiers from pointer target type
fs/quota/dquot.c:327: note: expected 'struct dquot **' but argument is of type 'struct dquot * const*'

Introduced by commit e91077e3d523c2ac2090b3447bf6244567cf7128 ("quota:
Move duplicated code to separate functions").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: ext3 tree build warning

[Dmitry Monakhov]

2009/12/15 Stephen Rothwell <sfr@canb.auug.org.au>:
> Hi Jan,
>
> Today's linux-next build (x86_64 allmodconfig) produced this warning:
>
> fs/quota/dquot.c: In function 'dquot_alloc_inode':
> fs/quota/dquot.c:1521: warning: passing argument 1 of 'mark_all_dquot_dirty' discards qualifiers from pointer target type
> fs/quota/dquot.c:327: note: expected 'struct dquot **' but argument is of type 'struct dquot * const*'
> fs/quota/dquot.c: In function 'dquot_free_inode':
> fs/quota/dquot.c:1649: warning: passing argument 1 of 'mark_all_dquot_dirty' discards qualifiers from pointer target type
> fs/quota/dquot.c:327: note: expected 'struct dquot **' but argument is of type 'struct dquot * const*'
What's why my original patch contained type casts.
In fact i dont understand why {alloc,free}_inode accept pointer to
const struct inode, it's contradicts to normal logic
Even if inode is not in a good state, quta code may and must(what's
how it designed for now) change it internals.
>
> Introduced by commit e91077e3d523c2ac2090b3447bf6244567cf7128 ("quota:
> Move duplicated code to separate functions").
>
> --
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/
>

Re: linux-next: ext3 tree build warning

[Jan Kara]

On Tue 15-12-09 12:58:36, Dmitry Monakhov wrote:
> 2009/12/15 Stephen Rothwell <sfr@canb.auug.org.au>:
> > Hi Jan,
> >
> > Today's linux-next build (x86_64 allmodconfig) produced this warning:
> >
> > fs/quota/dquot.c: In function 'dquot_alloc_inode':
> > fs/quota/dquot.c:1521: warning: passing argument 1 of 'mark_all_dquot_dirty' discards qualifiers from pointer target type
> > fs/quota/dquot.c:327: note: expected 'struct dquot **' but argument is of type 'struct dquot * const*'
> > fs/quota/dquot.c: In function 'dquot_free_inode':
> > fs/quota/dquot.c:1649: warning: passing argument 1 of 'mark_all_dquot_dirty' discards qualifiers from pointer target type
> > fs/quota/dquot.c:327: note: expected 'struct dquot **' but argument is of type 'struct dquot * const*'
> What's why my original patch contained type casts.
> In fact i dont understand why {alloc,free}_inode accept pointer to
> const struct inode, it's contradicts to normal logic
  Does it? The 'const' keyword just promises we won't change struct inode.
And that is true. We only change structures that are pointed to from the
inode.  So the code is correct as is. 

								Honza
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

Re: linux-next: ext3 tree build warning

[Jan Kara]

  Hi Stephen,

On Tue 15-12-09 10:59:25, Stephen Rothwell wrote:
> Today's linux-next build (x86_64 allmodconfig) produced this warning:
> 
> fs/quota/dquot.c: In function 'dquot_alloc_inode':
> fs/quota/dquot.c:1521: warning: passing argument 1 of 'mark_all_dquot_dirty' discards qualifiers from pointer target type
> fs/quota/dquot.c:327: note: expected 'struct dquot **' but argument is of type 'struct dquot * const*'
> fs/quota/dquot.c: In function 'dquot_free_inode':
> fs/quota/dquot.c:1649: warning: passing argument 1 of 'mark_all_dquot_dirty' discards qualifiers from pointer target type
> fs/quota/dquot.c:327: note: expected 'struct dquot **' but argument is of type 'struct dquot * const*'
> 
> Introduced by commit e91077e3d523c2ac2090b3447bf6244567cf7128 ("quota:
> Move duplicated code to separate functions").
  Sorry, I forgot to commit this compilation fix before pushing. It should
be fixed now.

								Honza
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

Re: linux-next: ext3 tree build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 296 bytes --]

Hi Jan,

On Tue, 15 Dec 2009 13:24:16 +0100 Jan Kara <jack@suse.cz> wrote:
>
>   Sorry, I forgot to commit this compilation fix before pushing. It should
> be fixed now.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]