mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-kernel@vger.kernel.org, Kay Sievers <kay.sievers@vrfy.org>
Subject: Re: devtmpfs [censored] oddities
Date: Wed, 16 Dec 2009 16:39:22 -0800	[thread overview]
Message-ID: <20091217003922.GB4863@suse.de> (raw)
In-Reply-To: <20091216080431.GF14381@ZenIV.linux.org.uk>

On Wed, Dec 16, 2009 at 08:04:31AM +0000, Al Viro wrote:
> 	May I respectfully suggest that a blocking operation (such as
> kstrdup with GFP_KERNEL, or grabbing a mutex, or, say it, pathname resolution)
> is not quite the thing to do while holding an rwlock?
> 
> 	As it is, any device_add() is an embarrassingly obvious deadlock
> waiting to happen...

Thomas has posted a patch to fix this now.

Sorry for not catching it sooner, we should just delete the rwlocks so
no one tries to ever use it again.

thanks,

greg k-h

  reply	other threads:[~2009-12-17  0:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-16  8:04 Al Viro
2009-12-17  0:39 ` Greg KH [this message]
2009-12-17  0:46   ` Al Viro
2009-12-17  1:00     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091217003922.GB4863@suse.de \
    --to=gregkh@suse.de \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®