From: Al Viro <viro@ZenIV.linux.org.uk>
To: Greg KH <gregkh@suse.de>
Cc: linux-kernel@vger.kernel.org, Kay Sievers <kay.sievers@vrfy.org>
Subject: Re: devtmpfs [censored] oddities
Date: Thu, 17 Dec 2009 00:46:43 +0000 [thread overview]
Message-ID: <20091217004643.GR14381@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20091217003922.GB4863@suse.de>
On Wed, Dec 16, 2009 at 04:39:22PM -0800, Greg KH wrote:
> On Wed, Dec 16, 2009 at 08:04:31AM +0000, Al Viro wrote:
> > May I respectfully suggest that a blocking operation (such as
> > kstrdup with GFP_KERNEL, or grabbing a mutex, or, say it, pathname resolution)
> > is not quite the thing to do while holding an rwlock?
> >
> > As it is, any device_add() is an embarrassingly obvious deadlock
> > waiting to happen...
>
> Thomas has posted a patch to fix this now.
>
> Sorry for not catching it sooner, we should just delete the rwlocks so
> no one tries to ever use it again.
Say again? Why would we delete rwlocks?
--
If you stare into drivers/staging long enough, drivers/staging stares back at
you...
next prev parent reply other threads:[~2009-12-17 0:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-16 8:04 Al Viro
2009-12-17 0:39 ` Greg KH
2009-12-17 0:46 ` Al Viro [this message]
2009-12-17 1:00 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091217004643.GR14381@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=gregkh@suse.de \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®