mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: linux-kernel@vger.kernel.org, stable@kernel.org
Cc: stable-review@kernel.org, torvalds@linux-foundation.org,
	akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk,
	Csaba Henk <csaba@gluster.com>, Miklos Szeredi <mszeredi@suse.cz>,
	Harshavardhana <harsha@gluster.com>
Subject: [04/18] fuse: reject O_DIRECT flag also in fuse_create
Date: Wed, 16 Dec 2009 16:45:55 -0800	[thread overview]
Message-ID: <20091217004707.472856791@mini.kroah.org> (raw)
In-Reply-To: <20091217005306.GA6230@kroah.com>

2.6.27-stable review patch.  If anyone has any objections, please let us know.

------------------
From: Csaba Henk <csaba@gluster.com>

commit 1b7323965a8c6eee9dc4e345a7ae4bff1dc93149 upstream.

The comment in fuse_open about O_DIRECT:

  "VFS checks this, but only _after_ ->open()"

also holds for fuse_create, however, the same kind of check was missing there.

As an impact of this bug, open(newfile, O_RDWR|O_CREAT|O_DIRECT) fails, but a
stub newfile will remain if the fuse server handled the implied FUSE_CREATE
request appropriately.

Other impact: in the above situation ima_file_free() will complain to open/free
imbalance if CONFIG_IMA is set.

Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
Cc: Harshavardhana <harsha@gluster.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 fs/fuse/dir.c |    3 +++
 1 file changed, 3 insertions(+)

--- a/fs/fuse/dir.c
+++ b/fs/fuse/dir.c
@@ -401,6 +401,9 @@ static int fuse_create_open(struct inode
 	if (flags & O_DIRECT)
 		return -EINVAL;
 
+	if (flags & O_DIRECT)
+		return -EINVAL;
+
 	forget_req = fuse_get_req(fc);
 	if (IS_ERR(forget_req))
 		return PTR_ERR(forget_req);



  parent reply	other threads:[~2009-12-17  0:59 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-17  0:53 [00/18] 2.6.27.42-stable review Greg KH
2009-12-17  0:45 ` [01/18] signal: Fix alternate signal stack check Greg KH
2009-12-17  0:45 ` [02/18] debugfs: fix create mutex racy fops and private data Greg KH
2009-12-17  0:45 ` [03/18] firewire: ohci: handle receive packets with a data length of zero Greg KH
2009-12-17  0:45 ` Greg KH [this message]
2009-12-17  1:36   ` [04/18] fuse: reject O_DIRECT flag also in fuse_create David Daney
2009-12-17  4:15     ` Greg KH
2009-12-17  0:45 ` [05/18] hfs: fix a potential buffer overflow Greg KH
2009-12-17  0:45 ` [06/18] pata_hpt{37x|3x2n}: fix timing register masks (take 2) Greg KH
2009-12-17  0:45 ` [07/18] ssb: Fix range check in sprom write Greg KH
2009-12-17  0:45 ` [08/18] V4L/DVB: Fix test in copy_reg_bits() Greg KH
2009-12-17  0:46 ` [09/18] x86, apic: Enable lapic nmi watchdog on AMD Family 11h Greg KH
2009-12-17  0:46 ` [10/18] x86: ASUS P4S800 reboot=bios quirk Greg KH
2009-12-17  0:46 ` [11/18] x86, Calgary IOMMU quirk: Find nearest matching Calgary while walking up the PCI tree Greg KH
2009-12-17  0:46 ` [12/18] x86: Fix iommu=nodac parameter handling Greg KH
2009-12-17  0:46 ` [13/18] x86: GART: pci-gart_64.c: Use correct length in strncmp Greg KH
2009-12-17  0:46 ` [14/18] [IA64] fix csum_ipv6_magic() Greg KH
2009-12-17  0:46 ` [15/18] USB: fix mos7840 problem with minor numbers Greg KH
2009-12-17  0:46 ` [16/18] backlight: lcd - Fix wrong sizeof Greg KH
2009-12-17  0:46 ` [17/18] jffs2: Fix long-standing bug with symlink garbage collection Greg KH
2009-12-17  0:46 ` [18/18] matroxfb: fix problems with display stability Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091217004707.472856791@mini.kroah.org \
    --to=gregkh@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=csaba@gluster.com \
    --cc=harsha@gluster.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mszeredi@suse.cz \
    --cc=stable-review@kernel.org \
    --cc=stable@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®