From: Greg KH <gregkh@suse.de>
To: linux-kernel@vger.kernel.org, stable@kernel.org
Cc: stable-review@kernel.org, torvalds@linux-foundation.org,
akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk,
David Woodhouse <David.Woodhouse@intel.com>
Subject: [17/18] jffs2: Fix long-standing bug with symlink garbage collection.
Date: Wed, 16 Dec 2009 16:46:08 -0800 [thread overview]
Message-ID: <20091217004709.378331483@mini.kroah.org> (raw)
In-Reply-To: <20091217005306.GA6230@kroah.com>
2.6.27-stable review patch. If anyone has any objections, please let us know.
------------------
From: David Woodhouse <David.Woodhouse@intel.com>
commit 2e16cfca6e17ae37ae21feca080a6f2eca9087dc upstream.
Ever since jffs2_garbage_collect_metadata() was first half-written in
February 2001, it's been broken on architectures where 'char' is signed.
When garbage collecting a symlink with target length above 127, the payload
length would end up negative, causing interesting and bad things to happen.
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
fs/jffs2/gc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/fs/jffs2/gc.c
+++ b/fs/jffs2/gc.c
@@ -700,7 +700,8 @@ static int jffs2_garbage_collect_metadat
struct jffs2_raw_inode ri;
struct jffs2_node_frag *last_frag;
union jffs2_device_node dev;
- char *mdata = NULL, mdatalen = 0;
+ char *mdata = NULL;
+ int mdatalen = 0;
uint32_t alloclen, ilen;
int ret;
next prev parent reply other threads:[~2009-12-17 0:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-17 0:53 [00/18] 2.6.27.42-stable review Greg KH
2009-12-17 0:45 ` [01/18] signal: Fix alternate signal stack check Greg KH
2009-12-17 0:45 ` [02/18] debugfs: fix create mutex racy fops and private data Greg KH
2009-12-17 0:45 ` [03/18] firewire: ohci: handle receive packets with a data length of zero Greg KH
2009-12-17 0:45 ` [04/18] fuse: reject O_DIRECT flag also in fuse_create Greg KH
2009-12-17 1:36 ` David Daney
2009-12-17 4:15 ` Greg KH
2009-12-17 0:45 ` [05/18] hfs: fix a potential buffer overflow Greg KH
2009-12-17 0:45 ` [06/18] pata_hpt{37x|3x2n}: fix timing register masks (take 2) Greg KH
2009-12-17 0:45 ` [07/18] ssb: Fix range check in sprom write Greg KH
2009-12-17 0:45 ` [08/18] V4L/DVB: Fix test in copy_reg_bits() Greg KH
2009-12-17 0:46 ` [09/18] x86, apic: Enable lapic nmi watchdog on AMD Family 11h Greg KH
2009-12-17 0:46 ` [10/18] x86: ASUS P4S800 reboot=bios quirk Greg KH
2009-12-17 0:46 ` [11/18] x86, Calgary IOMMU quirk: Find nearest matching Calgary while walking up the PCI tree Greg KH
2009-12-17 0:46 ` [12/18] x86: Fix iommu=nodac parameter handling Greg KH
2009-12-17 0:46 ` [13/18] x86: GART: pci-gart_64.c: Use correct length in strncmp Greg KH
2009-12-17 0:46 ` [14/18] [IA64] fix csum_ipv6_magic() Greg KH
2009-12-17 0:46 ` [15/18] USB: fix mos7840 problem with minor numbers Greg KH
2009-12-17 0:46 ` [16/18] backlight: lcd - Fix wrong sizeof Greg KH
2009-12-17 0:46 ` Greg KH [this message]
2009-12-17 0:46 ` [18/18] matroxfb: fix problems with display stability Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091217004709.378331483@mini.kroah.org \
--to=gregkh@suse.de \
--cc=David.Woodhouse@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=stable-review@kernel.org \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®