From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Rakib Mullick <rakib.mullick@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Alessandro Rubini <rubini@vision.unipv.it>
Subject: Re: [PATCH] input, mouse: Change the prototype of functions in lifebook.c
Date: Tue, 29 Dec 2009 22:19:55 -0800 [thread overview]
Message-ID: <20091230061955.GI2186@core.coreip.homeip.net> (raw)
In-Reply-To: <b9df5fa10912282009x5d0d2de4q36ab8a1f29d5a7de@mail.gmail.com>
On Tue, Dec 29, 2009 at 10:09:24AM +0600, Rakib Mullick wrote:
> When CONFIG_PM=n, then we are warned by the following warning:
>
> drivers/input/mouse/lifebook.c:33: warning: 'lifebook_limit_serio3'
> defined but not used
> drivers/input/mouse/lifebook.c:41: warning: 'lifebook_set_6byte_proto'
> defined but not used
>
I suppose it is CONFIG_DMI, not CONFIG_PM... In fact, we should simply
make this driver depend on CONFIG_DMI.
Thanks for reporting this.
--
Dmitry
next prev parent reply other threads:[~2009-12-30 6:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-29 4:09 Rakib Mullick
2009-12-30 6:19 ` Dmitry Torokhov [this message]
2009-12-30 13:29 ` Rakib Mullick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091230061955.GI2186@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rakib.mullick@gmail.com \
--cc=rubini@vision.unipv.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®