From: Rakib Mullick <rakib.mullick@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Alessandro Rubini <rubini@vision.unipv.it>
Subject: Re: [PATCH] input, mouse: Change the prototype of functions in lifebook.c
Date: Wed, 30 Dec 2009 19:29:01 +0600 [thread overview]
Message-ID: <b9df5fa10912300529i136c11daicc159a25795f8c2c@mail.gmail.com> (raw)
In-Reply-To: <20091230061955.GI2186@core.coreip.homeip.net>
On 12/30/09, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
>
> I suppose it is CONFIG_DMI, not CONFIG_PM... In fact, we should simply
> make this driver depend on CONFIG_DMI.
Oh.. yes. I made a stupid mistake. Please checkout the following patch.
-------
input, mouse: Make lifebook mouse driver depend on CONFIG_DMI.
When CONFIG_DMI=n, then we are warned by the following warning:
drivers/input/mouse/lifebook.c:33: warning: 'lifebook_limit_serio3'
defined but not used
drivers/input/mouse/lifebook.c:41: warning: 'lifebook_set_6byte_proto'
defined but not used
We need to make this driver depend on CONFIG_DMI.
Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
---
--- linus/drivers/input/mouse/Kconfig 2009-12-28 12:37:51.000000000 +0600
+++ rakib/drivers/input/mouse/Kconfig 2009-12-30 20:24:31.000000000 +0600
@@ -70,7 +70,7 @@ config MOUSE_PS2_SYNAPTICS
config MOUSE_PS2_LIFEBOOK
bool "Fujitsu Lifebook PS/2 mouse protocol extension" if EMBEDDED
default y
- depends on MOUSE_PS2 && X86
+ depends on MOUSE_PS2 && X86 && DMI
help
Say Y here if you have a Fujitsu B-series Lifebook PS/2
TouchScreen connected to your system.
prev parent reply other threads:[~2009-12-30 13:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-29 4:09 Rakib Mullick
2009-12-30 6:19 ` Dmitry Torokhov
2009-12-30 13:29 ` Rakib Mullick [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9df5fa10912300529i136c11daicc159a25795f8c2c@mail.gmail.com \
--to=rakib.mullick@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rubini@vision.unipv.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®