From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Andreas Mohr <andi@lisas.de>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux PCI <linux-pci@vger.kernel.org>,
pm list <linux-pm@lists.linux-foundation.org>,
Stephen Hemminger <shemminger@linux-foundation.org>,
"Maciej J. Woloszyk" <mat@esi.com.pl>
Subject: Re: [PATCH] PCI / PM: Use per-device D3 delays
Date: Fri, 1 Jan 2010 19:55:27 +0100 [thread overview]
Message-ID: <201001011955.27407.rjw@sisk.pl> (raw)
In-Reply-To: <20100101170729.GA22252@rhlx01.hs-esslingen.de>
On Friday 01 January 2010, Andreas Mohr wrote:
> Hi,
>
> While the bug report mentions "So it's just quirky hardware.",
> the implementation of your patch makes it seem like this delay attribute is
> totally "norm"al behaviour - I'm missing some more aggressive wording.
That's because it works both ways (please look at the changelog).
I know of a few devices that don't need the PCI-prescribed 10 ms wait when
going from D3 to D0 and their drivers may use the d3_delay field to actually
set a _shorter_ delay.
> Perhaps rename d3_delay to d3_delay__quirk or add something to the
> comment, like "D3->D0 transition time in ms (out-of-spec PCI device quirk)"?
> Or maybe something like
> "custom D3->D0 transition time in ms (for quirky hardware violating the PCI spec's <= 100ms)".
>
> Thanks for your ongoing great PCI efforts,
You're welcome.
Rafael
next prev parent reply other threads:[~2010-01-01 18:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-01 17:07 Andreas Mohr
2010-01-01 18:55 ` Rafael J. Wysocki [this message]
2010-01-01 20:12 ` Andreas Mohr
2010-01-01 21:42 ` Rafael J. Wysocki
2010-01-01 21:56 ` Andreas Mohr
-- strict thread matches above, loose matches on Subject: below --
2009-12-31 11:15 Rafael J. Wysocki
2010-01-04 23:48 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001011955.27407.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=andi@lisas.de \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mat@esi.com.pl \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®