Re: [uml-devel] linux-2.6.32 uml Segmentation fault

Re: [uml-devel] linux-2.6.32 uml Segmentation fault

[Geert Uytterhoeven]

On Sat, Dec 19, 2009 at 12:33, clownix <clownix@clownix.net> wrote:
> Hello
> For the 2.6.32 kernel there are 2 problems:
>
> 1: Compile error, this patch works for it:
> --------------------------------------------
>
> diff -Naur old_linux-2.6.32.1/security/keys/keyctl.c
> linux-2.6.32.1/security/keys/keyctl.c
> --- old_linux-2.6.32.1/security/keys/keyctl.c   2009-12-14
> 18:47:25.000000000 +0100
> +++ linux-2.6.32.1/security/keys/keyctl.c       2009-12-15 22:40:32.565286766
> +0100
> @@ -1236,6 +1236,7 @@
>  */
>  long keyctl_session_to_parent(void)
>  {
> +#ifdef TIF_NOTIFY_RESUME
>        struct task_struct *me, *parent;
>        const struct cred *mycred, *pcred;
>        struct cred *cred, *oldcred;
> @@ -1326,6 +1327,9 @@
>  error_keyring:
>        key_ref_put(keyring_r);
>        return ret;
> +#else /* !TIF_NOTIFY_RESUME */
> +       return -EOPNOTSUPP;
> +#endif /* !TIF_NOTIFY_RESUME */
>  }

Aha, UML is also affected.

Commit a00ae4d21b2fa9379914f270ffffd8d3bec55430 ("Keys:
KEYCTL_SESSION_TO_PARENT needs TIF_NOTIFY_RESUME architecture
support") should be in 2.6.32-stable as it fixes a regression, but
apparently the `Cc: stable@kernel.org' got lost?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

Re: [stable] [uml-devel] linux-2.6.32 uml Segmentation fault

[Greg KH]

On Sun, Dec 20, 2009 at 10:07:03AM +0100, Geert Uytterhoeven wrote:
> On Sat, Dec 19, 2009 at 12:33, clownix <clownix@clownix.net> wrote:
> > Hello
> > For the 2.6.32 kernel there are 2 problems:
> >
> > 1: Compile error, this patch works for it:
> > --------------------------------------------
> >
> > diff -Naur old_linux-2.6.32.1/security/keys/keyctl.c
> > linux-2.6.32.1/security/keys/keyctl.c
> > --- old_linux-2.6.32.1/security/keys/keyctl.c   2009-12-14
> > 18:47:25.000000000 +0100
> > +++ linux-2.6.32.1/security/keys/keyctl.c       2009-12-15 22:40:32.565286766
> > +0100
> > @@ -1236,6 +1236,7 @@
> >  */
> >  long keyctl_session_to_parent(void)
> >  {
> > +#ifdef TIF_NOTIFY_RESUME
> >        struct task_struct *me, *parent;
> >        const struct cred *mycred, *pcred;
> >        struct cred *cred, *oldcred;
> > @@ -1326,6 +1327,9 @@
> >  error_keyring:
> >        key_ref_put(keyring_r);
> >        return ret;
> > +#else /* !TIF_NOTIFY_RESUME */
> > +       return -EOPNOTSUPP;
> > +#endif /* !TIF_NOTIFY_RESUME */
> >  }
> 
> Aha, UML is also affected.
> 
> Commit a00ae4d21b2fa9379914f270ffffd8d3bec55430 ("Keys:
> KEYCTL_SESSION_TO_PARENT needs TIF_NOTIFY_RESUME architecture
> support") should be in 2.6.32-stable as it fixes a regression, but
> apparently the `Cc: stable@kernel.org' got lost?

Now queued up, thanks for letting me know.

greg k-h