* [PATCH] fs/notify/notification.c: make subsys_initcall static
@ 2010-01-15 2:56 H Hartley Sweeten
0 siblings, 0 replies; 3+ messages in thread
From: H Hartley Sweeten @ 2010-01-15 2:56 UTC (permalink / raw)
To: Linux Kernel
fs/notify/notification.c: make subsys_initcall static
The function fsnotify_notification_init is a subsys_initcall
and does not need to be exported. Make the function
static.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
---
diff --git a/fs/notify/notification.c b/fs/notify/notification.c
index b8bf53b..7f9a085 100644
--- a/fs/notify/notification.c
+++ b/fs/notify/notification.c
@@ -407,7 +407,7 @@ struct fsnotify_event *fsnotify_create_event(struct inode *to_tell, __u32 mask,
return event;
}
-__init int fsnotify_notification_init(void)
+static __init int fsnotify_notification_init(void)
{
fsnotify_event_cachep = KMEM_CACHE(fsnotify_event, SLAB_PANIC);
fsnotify_event_holder_cachep = KMEM_CACHE(fsnotify_event_holder, SLAB_PANIC);
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] fs/notify/notification.c: make subsys_initcall static
@ 2011-01-18 21:17 H Hartley Sweeten
2011-01-19 20:46 ` Eric Paris
0 siblings, 1 reply; 3+ messages in thread
From: H Hartley Sweeten @ 2011-01-18 21:17 UTC (permalink / raw)
To: Linux Kernel; +Cc: eparis, agruen
The symbol fsnotify_notification_init is a subsys_initcall and can be declared
static.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Eric Paris <eparis@redhat.com>
Cc: Andreas Gruenbacher <agruen@suse.de>
---
diff --git a/fs/notify/notification.c b/fs/notify/notification.c
index f39260f..85ae08f 100644
--- a/fs/notify/notification.c
+++ b/fs/notify/notification.c
@@ -447,7 +447,7 @@ struct fsnotify_event *fsnotify_create_event(struct inode *to_tell, __u32 mask,
return event;
}
-__init int fsnotify_notification_init(void)
+static __init int fsnotify_notification_init(void)
{
fsnotify_event_cachep = KMEM_CACHE(fsnotify_event, SLAB_PANIC);
fsnotify_event_holder_cachep = KMEM_CACHE(fsnotify_event_holder, SLAB_PANIC);
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] fs/notify/notification.c: make subsys_initcall static
2011-01-18 21:17 H Hartley Sweeten
@ 2011-01-19 20:46 ` Eric Paris
0 siblings, 0 replies; 3+ messages in thread
From: Eric Paris @ 2011-01-19 20:46 UTC (permalink / raw)
To: H Hartley Sweeten; +Cc: Linux Kernel, agruen
On Tue, 2011-01-18 at 14:17 -0700, H Hartley Sweeten wrote:
> The symbol fsnotify_notification_init is a subsys_initcall and can be declared
> static.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Eric Paris <eparis@redhat.com>
> Cc: Andreas Gruenbacher <agruen@suse.de>
Applied. Thanks and sorry to be so slow.
-Eric
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-01-19 20:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-01-15 2:56 [PATCH] fs/notify/notification.c: make subsys_initcall static H Hartley Sweeten
2011-01-18 21:17 H Hartley Sweeten
2011-01-19 20:46 ` Eric Paris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®