From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: alan@linux.intel.com, Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] serial: Two branches the same in timbuart_set_mctrl()
Date: Sun, 17 Jan 2010 18:17:02 +0000 [thread overview]
Message-ID: <20100117181702.026269e9@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <4B532CF5.7080000@gmail.com>
On Sun, 17 Jan 2010 16:29:57 +0100
Roel Kluin <roel.kluin@gmail.com> wrote:
> Regardless of the condition, the branches execute the same code
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> Was this maybe intended? please review.
I don't have data sheets and I'm very unwilling to play guess the
intended behaviour in the absence of an actual bug report.
I'd suggest you contanct the original author because as you note -
somthing looks odd indeed.
Alan
next prev parent reply other threads:[~2010-01-17 18:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-17 15:29 Roel Kluin
2010-01-17 18:17 ` Alan Cox [this message]
2010-01-17 19:02 ` Roel Kluin
2010-03-15 9:44 ` Richard Röjfors
2010-03-15 13:33 ` Roel Kluin
2010-03-15 13:41 ` Richard Röjfors
2010-03-15 13:57 ` Roel Kluin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100117181702.026269e9@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=alan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®