From: Arnd Bergmann <arnd@arndb.de>
To: Julia Lawall <julia@diku.dk>
Cc: Andreas Mohr <andi@lisas.de>,
linux-kernel@vger.kernel.org, Greg KH <greg@kroah.com>,
Alek Du <alek.du@intel.com>, Jacob Pan <jacob.jun.pan@intel.com>,
Alan Stern <stern@rowland.harvard.edu>
Subject: Re: mcs7830 usb net: "scheduling while atomic" danger?
Date: Mon, 18 Jan 2010 22:23:49 +0100 [thread overview]
Message-ID: <201001182223.49764.arnd@arndb.de> (raw)
In-Reply-To: <Pine.LNX.4.64.1001182206190.30446@ask.diku.dk>
On Monday 18 January 2010, Julia Lawall wrote:
> On Mon, 18 Jan 2010, Andreas Mohr wrote:
> >
> > Forgive me, but doesn't that mutex_lock()/msleep() (ab)use mean
> > risking a "scheduling while atomic"?
> > (such as discussed in e.g.
> > http://search.luky.org/linux-kernel.2004/msg92817.html )
> >
> >
> > And, if that is the case, shouldn't all such cases simply be killed for
> > good via a capable semantic patch?
>
> The semantic match shown below finds 55 matches. All but two involve
> mutex_lock. Those are in the file
> /var/linuxes/linux-next/drivers/usb/host/ehci-hub.c
> in the functions ehci_bus_suspend and ehci_hub_control.
That code looks indeed broken as was added las July as part of 331ac6b288d9
"USB: EHCI: Add Intel Moorestown EHCI controller HOSTPCx extensions and
support phy low power mode". The reason that this hasn't triggered is
probably the lack of Moorestown machines in the field.
Arnd
next prev parent reply other threads:[~2010-01-18 21:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 18:49 Andreas Mohr
2010-01-18 20:25 ` Julia Lawall
2010-01-18 20:47 ` Thomas Gleixner
2010-01-18 21:10 ` Julia Lawall
2010-01-18 21:23 ` Arnd Bergmann [this message]
2010-01-18 21:35 ` Julia Lawall
2010-01-18 22:25 ` Arnd Bergmann
2010-01-19 8:31 ` [PATCH] ehci: phy low power mode bug fixing alek du
2010-01-19 2:53 ` mcs7830 usb net: "scheduling while atomic" danger? Du, Alek
2010-01-19 6:25 ` Julia Lawall
2010-01-18 21:24 ` Thomas Gleixner
2010-01-18 21:32 ` Julia Lawall
2010-01-18 21:38 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001182223.49764.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=alek.du@intel.com \
--cc=andi@lisas.de \
--cc=greg@kroah.com \
--cc=jacob.jun.pan@intel.com \
--cc=julia@diku.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®