mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Julia Lawall <julia@diku.dk>
Cc: Andreas Mohr <andi@lisas.de>,
	linux-kernel@vger.kernel.org, Greg KH <greg@kroah.com>
Subject: Re: mcs7830 usb net: "scheduling while atomic" danger?
Date: Mon, 18 Jan 2010 22:24:12 +0100 (CET)	[thread overview]
Message-ID: <alpine.LFD.2.00.1001182219580.2906@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.64.1001182206190.30446@ask.diku.dk>

Julia,

On Mon, 18 Jan 2010, Julia Lawall wrote:
> On Mon, 18 Jan 2010, Andreas Mohr wrote:
>
> The semantic match shown below finds 55 matches.  All but two involve 
> mutex_lock.  Those are in the file 

As I said before the mutex_lock()/msleep() ones are fine. 

> /var/linuxes/linux-next/drivers/usb/host/ehci-hub.c
> in the functions ehci_bus_suspend and ehci_hub_control.

The msleep in ehci_hub_control() which happens with ehci->lock held
and irqs disabled is definitely buggy.

I can't see anything wrong wth the msleep in ehci_bus_suspend() as it
is _before_ the spin_lock_irq(&ehci->lock) region.

Thanks,

	tglx

  parent reply	other threads:[~2010-01-18 21:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-18 18:49 Andreas Mohr
2010-01-18 20:25 ` Julia Lawall
2010-01-18 20:47 ` Thomas Gleixner
2010-01-18 21:10 ` Julia Lawall
2010-01-18 21:23   ` Arnd Bergmann
2010-01-18 21:35     ` Julia Lawall
2010-01-18 22:25       ` Arnd Bergmann
2010-01-19  8:31         ` [PATCH] ehci: phy low power mode bug fixing alek du
2010-01-19  2:53     ` mcs7830 usb net: "scheduling while atomic" danger? Du, Alek
2010-01-19  6:25       ` Julia Lawall
2010-01-18 21:24   ` Thomas Gleixner [this message]
2010-01-18 21:32     ` Julia Lawall
2010-01-18 21:38       ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.1001182219580.2906@localhost.localdomain \
    --to=tglx@linutronix.de \
    --cc=andi@lisas.de \
    --cc=greg@kroah.com \
    --cc=julia@diku.dk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®