From: Roland McGrath <roland@redhat.com>
To: "Lu, Hongjiu" <hongjiu.lu@intel.com>
Cc: "Siddha, Suresh B" <suresh.b.siddha@intel.com>,
Oleg Nesterov <oleg@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
"Lachner, Peter" <peter.lachner@intel.com>
Subject: RE: [patch] x86: ptrace and core-dump extensions for xstate
Date: Wed, 3 Feb 2010 20:54:58 -0800 (PST) [thread overview]
Message-ID: <20100204045458.5AA2F7290@magilla.sf.frob.com> (raw)
In-Reply-To: Lu, Hongjiu's message of Wednesday, 3 February 2010 18:22:53 -0800 <8EA2C2C4116BF44AB370468FBF85A7770123AAB303@orsmsx504.amr.corp.intel.com>
> To support XSAVE, gdb needs to know XCR0 as well as XSTATE size.
> We can get those info from kernel via system call or cpuid. I
> prefer cpuid over system call.
Suresh's patch puts this value in the xsave block, in what Suresh calls
"sw_usable_bytes". See the asm/ptrace-abi.h comment in the patch you
signed off on.
How is that not sufficient? If it is indeed not sufficient to usefully
interpret the xsave block, then how could an xsave block in a core dump
file ever possibly be examined if it might not have been generated on the
same system and kernel where the debugger is doing the examination? If
the NT_X86_XSTATE note as implemented in Suresh's patch is indeed not
entirely self-contained in this way, then NAK on that new note format.
Thanks,
Roland
next prev parent reply other threads:[~2010-02-04 4:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-02 2:00 Suresh Siddha
2010-02-02 2:33 ` [tip:x86/ptrace] " tip-bot for Suresh Siddha
2010-02-03 23:08 ` [patch] " Roland McGrath
2010-02-03 23:45 ` Lu, Hongjiu
2010-02-04 2:02 ` Roland McGrath
2010-02-04 2:05 ` Lu, Hongjiu
2010-02-04 2:16 ` Roland McGrath
2010-02-04 2:22 ` Lu, Hongjiu
2010-02-04 4:54 ` Roland McGrath [this message]
2010-02-04 5:01 ` Lu, Hongjiu
2010-02-04 5:18 ` Roland McGrath
2010-02-04 5:32 ` Lu, Hongjiu
2010-02-04 20:28 ` Suresh Siddha
2010-02-04 20:55 ` Roland McGrath
2010-02-04 22:05 ` Suresh Siddha
2010-02-04 22:18 ` H. Peter Anvin
2010-02-05 19:47 ` Lu, Hongjiu
2010-02-05 21:15 ` Roland McGrath
2010-02-05 21:39 ` Suresh Siddha
2010-02-09 17:28 ` Oleg Nesterov
2010-02-05 21:02 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100204045458.5AA2F7290@magilla.sf.frob.com \
--to=roland@redhat.com \
--cc=hongjiu.lu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=peter.lachner@intel.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®