mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roland McGrath <roland@redhat.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>,
	Oleg Nesterov <oleg@redhat.com>, Ingo Molnar <mingo@elte.hu>,
	Thomas Gleixner <tglx@linutronix.de>,
	LKML <linux-kernel@vger.kernel.org>,
	"Lu, Hongjiu" <hongjiu.lu@intel.com>,
	"Lachner, Peter" <peter.lachner@intel.com>
Subject: Re: [patch] x86: ptrace and core-dump extensions for xstate
Date: Fri,  5 Feb 2010 13:15:15 -0800 (PST)	[thread overview]
Message-ID: <20100205211515.9805FE7@magilla.sf.frob.com> (raw)
In-Reply-To: H. Peter Anvin's message of  Thursday, 4 February 2010 14:18:09 -0800 <4B6B47A1.3050606@zytor.com>

> #define PTRACE_GETREGS(r) (((r) << 16) | PTRACE_GETREGS_CMD)
> 
> ... or something like that?

(You can't use that exact name, it's taken.)  IMHO this is some spurious
obfuscation that is not warranted by saving the two get_user calls in the
kernel.  (OTOH, my suggestion requires a whole extra 5 lines of code or so
in compat_sys_ptrace because the indirection in the ABI is sensitive to
userland word size.)  But I don't feel strongly about the particulars of
the ptrace API addition, just that it be generic to cover any regset and
not be prone to implicit buffer-size miscommunications.  I'll leave it to
whatever Oleg wants to implement.


Thanks,
Roland

  parent reply	other threads:[~2010-02-05 21:16 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-02  2:00 Suresh Siddha
2010-02-02  2:33 ` [tip:x86/ptrace] " tip-bot for Suresh Siddha
2010-02-03 23:08 ` [patch] " Roland McGrath
2010-02-03 23:45   ` Lu, Hongjiu
2010-02-04  2:02     ` Roland McGrath
2010-02-04  2:05       ` Lu, Hongjiu
2010-02-04  2:16         ` Roland McGrath
2010-02-04  2:22           ` Lu, Hongjiu
2010-02-04  4:54             ` Roland McGrath
2010-02-04  5:01               ` Lu, Hongjiu
2010-02-04  5:18                 ` Roland McGrath
2010-02-04  5:32                   ` Lu, Hongjiu
2010-02-04 20:28   ` Suresh Siddha
2010-02-04 20:55     ` Roland McGrath
2010-02-04 22:05       ` Suresh Siddha
2010-02-04 22:18         ` H. Peter Anvin
2010-02-05 19:47           ` Lu, Hongjiu
2010-02-05 21:15           ` Roland McGrath [this message]
2010-02-05 21:39             ` Suresh Siddha
2010-02-09 17:28               ` Oleg Nesterov
2010-02-05 21:02         ` Roland McGrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100205211515.9805FE7@magilla.sf.frob.com \
    --to=roland@redhat.com \
    --cc=hongjiu.lu@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oleg@redhat.com \
    --cc=peter.lachner@intel.com \
    --cc=suresh.b.siddha@intel.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®