* radeonfb backlight fix
@ 2010-02-16 18:19 James Simmons
2010-02-22 20:23 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: James Simmons @ 2010-02-16 18:19 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Linux Fbdev development list, Linux Kernel Mailing List
A simple patch to allow radeonfb to compile if the backlight option is
set.
diff --git a/drivers/video/aty/radeon_base.c b/drivers/video/aty/radeon_base.c
index 6c37e8e..2c01726 100644
--- a/drivers/video/aty/radeon_base.c
+++ b/drivers/video/aty/radeon_base.c
@@ -276,7 +276,7 @@ static int nomtrr = 0;
#endif
static int force_sleep;
static int ignore_devlist;
-#ifdef CONFIG_PMAC_BACKLIGHT
+#ifdef CONFIG_FB_RADEON_BACKLIGHT
static int backlight = 1;
#else
static int backlight = 0;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: radeonfb backlight fix
2010-02-16 18:19 radeonfb backlight fix James Simmons
@ 2010-02-22 20:23 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2010-02-22 20:23 UTC (permalink / raw)
To: James Simmons
Cc: Linus Torvalds, Linux Fbdev development list, Linux Kernel Mailing List
On Tue, 16 Feb 2010 18:19:21 +0000 (GMT) James Simmons <jsimmons@infradead.org> wrote:
>
> A simple patch to allow radeonfb to compile if the backlight option is
> set.
>
> diff --git a/drivers/video/aty/radeon_base.c b/drivers/video/aty/radeon_base.c
> index 6c37e8e..2c01726 100644
> --- a/drivers/video/aty/radeon_base.c
> +++ b/drivers/video/aty/radeon_base.c
> @@ -276,7 +276,7 @@ static int nomtrr = 0;
> #endif
> static int force_sleep;
> static int ignore_devlist;
> -#ifdef CONFIG_PMAC_BACKLIGHT
> +#ifdef CONFIG_FB_RADEON_BACKLIGHT
> static int backlight = 1;
> #else
> static int backlight = 0;
Changelog is very poor. It doesn't tell us what the error was, nor how
the patch fixes it.
I attempted to reverse-engineer the patch but gave up.
radeonfb_bl_init() is omitted from the link if
CONFIG_FB_RADEON_BACKLIGHT=n. And this code:
if (backlight)
radeonfb_bl_init(rinfo);
will emit a call to radeonfb_bl_init() regardless of the value of
`backlight', so as far as I can tell, there will be a linkage error
with CONFIG_FB_RADEON_BACKLIGHT=n both before and after your patch.
So. Please resend, with a proper description. And a Signed-off-by: line.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-22 20:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-02-16 18:19 radeonfb backlight fix James Simmons
2010-02-22 20:23 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®