From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Amit Shah <amit.shah@redhat.com>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH] hvc_console: Fix a race between hvc_close and hvc_remove
Date: Sat, 27 Feb 2010 01:33:59 +0000 [thread overview]
Message-ID: <20100227013359.5e50f032@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1267184786-4377-1-git-send-email-amit.shah@redhat.com>
> + tty_kref_get(hp->tty);
> spin_lock_irqsave(&hp->lock, flags);
> tty = hp->tty;
>
> @@ -830,7 +833,9 @@ int hvc_remove(struct hvc_struct *hp)
> * cleaned up the hvc_struct.
> */
> if (tty)
> - tty_hangup(tty);
> + tty_vhangup(tty);
> +
> + tty_kref_put(hp->tty);
You need to deref hp->tty, take the kref under the lock (and indeed do
all assignments to it that way too), then tty_kref_put(tty), otherwise
what stops hp->tty changing during the remove ?
Take a look how tty_port_tty_get() and tty_port.c does it ...
Alan
prev parent reply other threads:[~2010-02-27 1:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-26 11:46 Amit Shah
2010-02-27 1:33 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100227013359.5e50f032@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=amit.shah@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®