mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dominik Brodowski <linux@dominikbrodowski.net>
To: Jan Beulich <JBeulich@novell.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	alan@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: pcmcia's use of IRQ_NOAUTOEN
Date: Mon, 8 Mar 2010 20:47:57 +0100	[thread overview]
Message-ID: <20100308194757.GB17628@isilmar.linta.de> (raw)
In-Reply-To: <4B94DCB7020000780003337B@vpn.id2.novell.com>

Hey,

On Mon, Mar 08, 2010 at 10:17:11AM +0000, Jan Beulich wrote:
> (re-sending to correct Alan's email address)
> 
> Commit 635416ef393e8cec5a89fc6c1de710ee9596a51e introduced
> this, but I can't see how it can take effect - the argument passed to
> request_irq() only affects action->flags (IRQF_*), whereas the flag
> in question is a desc->status one (IRQ_*). Am I overlooking
> something? If not, while currently this just should not work as expected,
> it's latently more significant (as soon as the IRQF_* definitions make
> use of the bit used by IRQ_NOAUTOEN).

You're right, it seems to make no sense. Or less than that.

Alan, what do you think?

Best,
	Dominik

  reply	other threads:[~2010-03-08 19:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-08 10:17 Jan Beulich
2010-03-08 19:47 ` Dominik Brodowski [this message]
2010-03-15 17:43   ` Alan Cox
2010-03-15 18:18     ` Dominik Brodowski
  -- strict thread matches above, loose matches on Subject: below --
2010-03-08 10:11 Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100308194757.GB17628@isilmar.linta.de \
    --to=linux@dominikbrodowski.net \
    --cc=JBeulich@novell.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®