From: Dominik Brodowski <linux@dominikbrodowski.net>
To: Alan Cox <alan@linux.intel.com>
Cc: Jan Beulich <JBeulich@novell.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: pcmcia's use of IRQ_NOAUTOEN
Date: Mon, 15 Mar 2010 19:18:29 +0100 [thread overview]
Message-ID: <20100315181829.GA26096@isilmar.linta.de> (raw)
In-Reply-To: <20100315174359.7fa53d4b@linux.intel.com>
Hey,
On Mon, Mar 15, 2010 at 05:43:59PM +0000, Alan Cox wrote:
> > You're right, it seems to make no sense. Or less than that.
> >
> > Alan, what do you think?
>
> It should be setting the correct NOAUTOEN bits so that the IRQ isn't
> randomly enabled as some hardware then crashes. How it ended up wrong
> upstream I don't know as it was tested and fixed the bug, so presumably
> the right version got tested or it happened to work back on the old irq
> code by luck.
http://lkml.org/lkml/2007/4/5/127 and then
http://lkml.org/lkml/2007/4/26/485 talk a different language :(
> I don't think you are overlooking anything - there is no deep magic
> involved.
I'll just revert it.
Best,
Dominik
next prev parent reply other threads:[~2010-03-15 18:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-08 10:17 Jan Beulich
2010-03-08 19:47 ` Dominik Brodowski
2010-03-15 17:43 ` Alan Cox
2010-03-15 18:18 ` Dominik Brodowski [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-03-08 10:11 Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100315181829.GA26096@isilmar.linta.de \
--to=linux@dominikbrodowski.net \
--cc=JBeulich@novell.com \
--cc=akpm@linux-foundation.org \
--cc=alan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®