[PATCH] Staging: comedi:fix missing KERN_facility level in ni_labpc.c

[PATCH] Staging: comedi:fix missing KERN_facility level in ni_labpc.c

[aseem sethi]

From: aseemsethi <aseemsethi@yahoo.com>
 This is a patch to fix the "missing KERN_facility level" error found when running the checkpatch.pl script
 Signed-off-by: Aseem Sethi <aseemsethi@yahoo.com>

---
 drivers/staging/comedi/drivers/ni_labpc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/comedi/drivers/ni_labpc.c b/drivers/staging/comedi/drivers/ni_labpc.c
index 3c88caa..63853c2 100644
--- a/drivers/staging/comedi/drivers/ni_labpc.c
+++ b/drivers/staging/comedi/drivers/ni_labpc.c
@@ -535,7 +535,7 @@ int labpc_common_attach(struct comedi_device *dev, unsigned long iobase,
        printk("\n");
 
        if (iobase == 0) {
-               printk("io base address is zero!\n");
+               printk(KERN_ERR "io base address is zero!\n");
                return -EINVAL;
        }
        /*  request io regions for isa boards */
-- 
1.6.4.2
__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 

Re: [PATCH] Staging: comedi:fix missing KERN_facility level in ni_labpc.c

[Randy Dunlap]

On 03/09/10 10:34, aseem sethi wrote:
> From: aseemsethi <aseemsethi@yahoo.com>
>  This is a patch to fix the "missing KERN_facility level" error found when running the checkpatch.pl script
>  Signed-off-by: Aseem Sethi <aseemsethi@yahoo.com>
> 
> ---
>  drivers/staging/comedi/drivers/ni_labpc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/ni_labpc.c b/drivers/staging/comedi/drivers/ni_labpc.c
> index 3c88caa..63853c2 100644
> --- a/drivers/staging/comedi/drivers/ni_labpc.c
> +++ b/drivers/staging/comedi/drivers/ni_labpc.c
> @@ -535,7 +535,7 @@ int labpc_common_attach(struct comedi_device *dev, unsigned long iobase,
>         printk("\n");
>  
>         if (iobase == 0) {
> -               printk("io base address is zero!\n");
> +               printk(KERN_ERR "io base address is zero!\n");
>                 return -EINVAL;
>         }
>         /*  request io regions for isa boards */


Hi,

How does someone know that this message comes from this driver and
not from some other driver or core part of the kernel?


I'd be much more interested in someone fixing comedi build errors (that have
been around forever -- I reported these long ago) when CONFIG_PCI=n and
CONFIG_COMEDI=m, CONFIG_COMEDI_PCMCIA=m, CONFIG_PCCARD=y, CONFIG_PCMCIA=y,
but CONFIG_CARDBUS=n:

ERROR: "ni_tio_rinsn" [drivers/staging/comedi/drivers/ni_mio_cs.ko] undefined!
ERROR: "ni_tio_winsn" [drivers/staging/comedi/drivers/ni_mio_cs.ko] undefined!
ERROR: "ni_tio_insn_config" [drivers/staging/comedi/drivers/ni_mio_cs.ko] undefined!
ERROR: "ni_tio_init_counter" [drivers/staging/comedi/drivers/ni_mio_cs.ko] undefined!
ERROR: "ni_gpct_device_construct" [drivers/staging/comedi/drivers/ni_mio_cs.ko] undefined!
ERROR: "ni_gpct_device_destroy" [drivers/staging/comedi/drivers/ni_mio_cs.ko] undefined!
ERROR: "labpc_1200_is_unipolar" [drivers/staging/comedi/drivers/ni_labpc_cs.ko] undefined!
ERROR: "labpc_1200_ai_gain_bits" [drivers/staging/comedi/drivers/ni_labpc_cs.ko] undefined!
ERROR: "range_labpc_1200_ai" [drivers/staging/comedi/drivers/ni_labpc_cs.ko] undefined!
ERROR: "labpc_common_detach" [drivers/staging/comedi/drivers/ni_labpc_cs.ko] undefined!
ERROR: "labpc_common_attach" [drivers/staging/comedi/drivers/ni_labpc_cs.ko] undefined!
ERROR: "das08_cs_boards" [drivers/staging/comedi/drivers/das08_cs.ko] undefined!
ERROR: "das08_common_detach" [drivers/staging/comedi/drivers/das08_cs.ko] undefined!
ERROR: "das08_common_attach" [drivers/staging/comedi/drivers/das08_cs.ko] undefined!

I.e., the "pcmcia" drivers are probably cardbus drivers (or at least some of them are),
but there is no differentiation between PCMCIA and CARDBUS.


-- 
~Randy