mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Prarit Bhargava <prarit@redhat.com>
To: linux-kernel@vger.kernel.org, yinghai@kernel.org
Cc: Prarit Bhargava <prarit@redhat.com>
Subject: [PATCH]: cleanup debug message in irq_to_desc_alloc_node()
Date: Wed, 10 Mar 2010 08:45:10 -0500	[thread overview]
Message-ID: <20100310134510.16144.50619.sendpatchset@prarit.bos.redhat.com> (raw)

Clean up debug messages in irq_to_desc_alloc_node().

This debug message can result in valid output like

	alloc irq_desc for 73 on node -1

which looks like alot like an error message.

This debug statement has been in the kernel for about a year, so I think it is
safe to remove it and report the irq and node in the error case instead.

Signed-off-by: Prarit Bhargava <prarit@redhat.com>

diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c
index 17c71bb..5c3e38e 100644
--- a/kernel/irq/handle.c
+++ b/kernel/irq/handle.c
@@ -224,9 +224,10 @@ struct irq_desc * __ref irq_to_desc_alloc_node(unsigned int irq, int node)
 	else
 		desc = alloc_bootmem_node(NODE_DATA(node), sizeof(*desc));
 
-	printk(KERN_DEBUG "  alloc irq_desc for %d on node %d\n", irq, node);
 	if (!desc) {
-		printk(KERN_ERR "can not alloc irq_desc\n");
+		printk(KERN_ERR
+		       "can not alloc irq_desc for irq %d on node %d\n",
+		       irq, node);
 		BUG_ON(1);
 	}
 	init_one_irq_desc(irq, desc, node);

                 reply	other threads:[~2010-03-10 13:45 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100310134510.16144.50619.sendpatchset@prarit.bos.redhat.com \
    --to=prarit@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®