mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH]: cleanup debug message in irq_to_desc_alloc_node()
@ 2010-03-10 13:45 Prarit Bhargava
  0 siblings, 0 replies; only message in thread
From: Prarit Bhargava @ 2010-03-10 13:45 UTC (permalink / raw)
  To: linux-kernel, yinghai; +Cc: Prarit Bhargava

Clean up debug messages in irq_to_desc_alloc_node().

This debug message can result in valid output like

	alloc irq_desc for 73 on node -1

which looks like alot like an error message.

This debug statement has been in the kernel for about a year, so I think it is
safe to remove it and report the irq and node in the error case instead.

Signed-off-by: Prarit Bhargava <prarit@redhat.com>

diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c
index 17c71bb..5c3e38e 100644
--- a/kernel/irq/handle.c
+++ b/kernel/irq/handle.c
@@ -224,9 +224,10 @@ struct irq_desc * __ref irq_to_desc_alloc_node(unsigned int irq, int node)
 	else
 		desc = alloc_bootmem_node(NODE_DATA(node), sizeof(*desc));
 
-	printk(KERN_DEBUG "  alloc irq_desc for %d on node %d\n", irq, node);
 	if (!desc) {
-		printk(KERN_ERR "can not alloc irq_desc\n");
+		printk(KERN_ERR
+		       "can not alloc irq_desc for irq %d on node %d\n",
+		       irq, node);
 		BUG_ON(1);
 	}
 	init_one_irq_desc(irq, desc, node);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-03-10 13:45 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-10 13:45 [PATCH]: cleanup debug message in irq_to_desc_alloc_node() Prarit Bhargava

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®