From: Prarit Bhargava <prarit@redhat.com>
To: linux-kernel@vger.kernel.org, yinghai@kernel.org
Cc: Prarit Bhargava <prarit@redhat.com>
Subject: [PATCH]: cleanup debug message in init_kstat_irqs()
Date: Wed, 10 Mar 2010 09:05:35 -0500 [thread overview]
Message-ID: <20100310140535.16273.90102.sendpatchset@prarit.bos.redhat.com> (raw)
Cleanup a debug message in init_kstat_irqs().
This debug message can result in valid output like
alloc kstat_irqs on node -1
which looks alot like an error message.
This debug statement has been in the kernel for over a year, so I think it is
safe to remove it and report the node in only the error case instead.
Signed-off-by: Prarit Bhargava <prarit@redhat.com>
diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c
index 76d5a67..e7fb871 100644
--- a/kernel/irq/handle.c
+++ b/kernel/irq/handle.c
@@ -94,10 +94,10 @@ void __ref init_kstat_irqs(struct irq_desc *desc, int node, int nr)
* don't overwite if can not get new one
* init_copy_kstat_irqs() could still use old one
*/
- if (ptr) {
- printk(KERN_DEBUG " alloc kstat_irqs on node %d\n", node);
+ if (ptr)
desc->kstat_irqs = ptr;
- }
+ else
+ printk(KERN_ERR " alloc kstat_irqs on node %d failed\n", node);
}
reply other threads:[~2010-03-10 14:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100310140535.16273.90102.sendpatchset@prarit.bos.redhat.com \
--to=prarit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome