mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH]: cleanup debug message in init_kstat_irqs()
@ 2010-03-10 14:05 Prarit Bhargava
  0 siblings, 0 replies; only message in thread
From: Prarit Bhargava @ 2010-03-10 14:05 UTC (permalink / raw)
  To: linux-kernel, yinghai; +Cc: Prarit Bhargava

Cleanup a debug message in init_kstat_irqs().

This debug message can result in valid output like

	alloc kstat_irqs on node -1

which looks alot like an error message.

This debug statement has been in the kernel for over a year, so I think it is
safe to remove it and report the node in only the error case instead.

Signed-off-by: Prarit Bhargava <prarit@redhat.com>

diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c
index 76d5a67..e7fb871 100644
--- a/kernel/irq/handle.c
+++ b/kernel/irq/handle.c
@@ -94,10 +94,10 @@ void __ref init_kstat_irqs(struct irq_desc *desc, int node, int nr)
 	 * don't overwite if can not get new one
 	 * init_copy_kstat_irqs() could still use old one
 	 */
-	if (ptr) {
-		printk(KERN_DEBUG "  alloc kstat_irqs on node %d\n", node);
+	if (ptr)
 		desc->kstat_irqs = ptr;
-	}
+	else
+		printk(KERN_ERR "  alloc kstat_irqs on node %d failed\n", node);
 }
 

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-03-10 14:05 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-10 14:05 [PATCH]: cleanup debug message in init_kstat_irqs() Prarit Bhargava

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome