mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] USB-SERIAL cp210x: Remove double usb_control_msg from cp210x_set_config
@ 2010-03-10 22:26 Michael Brunner
  0 siblings, 0 replies; only message in thread
From: Michael Brunner @ 2010-03-10 22:26 UTC (permalink / raw)
  To: craig, gregkh; +Cc: linux-usb, linux-kernel

This patch removes a double usb_control_msg that sets the cp210x
configuration registers a second time when calling cp210x_set_config.
For data sizes >2 the second write gets corrupted.
The patch has been created against 2.6.34-rc1, but all cp210x driver
revisions are affected.

Signed-off-by: Michael Brunner <mibru@gmx.de>
---
 drivers/usb/serial/cp210x.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index 507382b..ec9b044 100644
--- a/drivers/usb/serial/cp210x.c
+++ b/drivers/usb/serial/cp210x.c
@@ -313,11 +313,6 @@ static int cp210x_set_config(struct usb_serial_port *port, 
        return -EPROTO;
    }
 
-   /* Single data value */
-   result = usb_control_msg(serial->dev,
-           usb_sndctrlpipe(serial->dev, 0),
-           request, REQTYPE_HOST_TO_DEVICE, data[0],
-           0, NULL, 0, 300);
    return 0;
 }
 

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-03-10 22:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-10 22:26 [PATCH] USB-SERIAL cp210x: Remove double usb_control_msg from cp210x_set_config Michael Brunner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®