From: "Ira W. Snyder" <iws@ovro.caltech.edu>
To: Wolfgang Grandegger <wg@grandegger.com>
Cc: socketcan-core@lists.berlios.de, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, sameo@linux.intel.com
Subject: Re: [PATCH 2/3] can: add support for Janz VMOD-ICAN3 Intelligent CAN module
Date: Mon, 22 Mar 2010 13:51:01 -0700 [thread overview]
Message-ID: <20100322205101.GC19327@ovro.caltech.edu> (raw)
In-Reply-To: <4BA7D2E9.6010007@grandegger.com>
On Mon, Mar 22, 2010 at 09:28:25PM +0100, Wolfgang Grandegger wrote:
[ big snip ]
>
> You could even add the tx/rx values for each error message (for both,
> state changes and bus-errors).
>
Ok, with that change, I get the following:
berr-reporting on:
can0 20000088 [8] 00 00 80 19 00 00 08 00 ERRORFRAME
can0 20000088 [8] 00 00 80 19 00 00 10 00 ERRORFRAME
can0 20000088 [8] 00 00 80 19 00 00 18 00 ERRORFRAME
can0 20000088 [8] 00 00 80 19 00 00 20 00 ERRORFRAME
can0 20000088 [8] 00 00 80 19 00 00 28 00 ERRORFRAME
can0 20000088 [8] 00 00 80 19 00 00 30 00 ERRORFRAME
can0 20000088 [8] 00 00 80 19 00 00 38 00 ERRORFRAME
can0 20000088 [8] 00 00 80 19 00 00 40 00 ERRORFRAME
can0 20000088 [8] 00 00 80 19 00 00 48 00 ERRORFRAME
can0 20000088 [8] 00 00 80 19 00 00 50 00 ERRORFRAME
can0 20000088 [8] 00 00 80 19 00 00 58 00 ERRORFRAME
can0 20000004 [8] 00 08 00 00 00 00 60 00 ERRORFRAME
can0 20000088 [8] 00 00 80 19 00 00 60 00 ERRORFRAME
can0 20000088 [8] 00 00 80 19 00 00 68 00 ERRORFRAME
can0 20000088 [8] 00 00 80 19 00 00 70 00 ERRORFRAME
can0 20000088 [8] 00 00 80 19 00 00 78 00 ERRORFRAME
can0 20000004 [8] 00 20 00 00 00 00 80 00 ERRORFRAME
can0 20000088 [8] 00 00 80 19 00 00 80 00 ERRORFRAME
can0 20000088 [8] 00 00 80 19 00 00 80 00 ERRORFRAME
And now lots more of this last frame repeated, until the controller
decides to stop. Seems fine. It has always done this.
berr-reporting off:
can1 20000004 [8] 00 08 00 00 00 00 60 00 ERRORFRAME
can1 20000004 [8] 00 20 00 00 00 00 80 00 ERRORFRAME
Same as before. Excellent.
> > I haven't heard back from Samuel Ortiz yet about the changes for the mfd
> > layer. Would you like me to send out my latest CAN driver changes, or
> > should I just wait until I hear back?
>
> As you need patch 1/3 anyway, just wait some more time. From my point of
> view the next version of the patch will be OK.
>
Ok, I'll wait a few more days before pinging him again. He's CC'd on all
of these emails anyway. :)
Thanks for all the help,
Ira
next prev parent reply other threads:[~2010-03-22 20:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-18 16:38 Ira W. Snyder
2010-03-19 9:01 ` Wolfgang Grandegger
2010-03-19 15:19 ` Ira W. Snyder
2010-03-19 15:45 ` Wolfgang Grandegger
2010-03-19 20:03 ` Ira W. Snyder
2010-03-19 20:13 ` Wolfgang Grandegger
2010-03-19 21:52 ` Ira W. Snyder
2010-03-20 7:55 ` Wolfgang Grandegger
2010-03-22 15:53 ` Ira W. Snyder
2010-03-22 19:17 ` Wolfgang Grandegger
2010-03-22 19:23 ` Wolfgang Grandegger
2010-03-22 20:12 ` Ira W. Snyder
2010-03-22 20:10 ` Ira W. Snyder
2010-03-22 20:28 ` Wolfgang Grandegger
2010-03-22 20:51 ` Ira W. Snyder [this message]
2010-03-22 21:24 ` Wolfgang Grandegger
-- strict thread matches above, loose matches on Subject: below --
2010-03-29 16:58 Ira W. Snyder
2010-03-30 8:14 ` Wolfgang Grandegger
2010-03-31 6:46 ` David Miller
2010-04-01 20:03 ` Andrew Morton
2010-04-02 0:43 ` Ira W. Snyder
2010-03-02 21:22 [PATCH 0/3 RFCv4] add support for Janz MODULbus devices Ira W. Snyder
2010-03-02 21:22 ` [PATCH 2/3] can: add support for Janz VMOD-ICAN3 Intelligent CAN module Ira W. Snyder
2010-03-17 19:33 ` Ira W. Snyder
2010-03-18 8:36 ` Wolfgang Grandegger
2010-03-18 15:19 ` Ira W. Snyder
2010-03-18 16:06 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100322205101.GC19327@ovro.caltech.edu \
--to=iws@ovro.caltech.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=socketcan-core@lists.berlios.de \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome