mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: unlisted-recipients:; (no To-header on input)
Cc: Pavan Savoy <pavan_savoy@ti.com>,
	gregkh@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] drivers:misc: sources for ST core
Date: Tue, 23 Mar 2010 20:28:21 +0000	[thread overview]
Message-ID: <20100323202821.22f7c7f0@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <420891.23395.qm@web94909.mail.in2.yahoo.com>

> > [alan]
> > >What if you have multiple devices at once one in each
> > state ?
> > >Why is this global ?
> > 
> > [pavan]
> > st_gdata required in non-tty calls as well.
> > 
> > [pavan]
> > Can't happen, The chip on doing a UART write will either
> > write whole of BT data or whole of FM, so it can't be in
> > multiple states.

What if you have two chips ?

> > st_gdata not in tty priv data or ldisc_data because there
> > are entry points like st_register/unregister which are
> > EXPORTed requires it.

We need to fix that I think so there is some kind of context that is per
device.

> > If the rest seems fine, please consider it for staging,
> > Will keep reworking on it.

I'm happy with it going that way and that means I can then send patches
and suggestions to clean it up bit by bit.

  reply	other threads:[~2010-03-23 20:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-23 15:42 Pavan Savoy
2010-03-23 19:59 ` Pavan Savoy
2010-03-23 20:28   ` Alan Cox [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-03-23 16:44 Pavan Savoy
2010-03-22 21:19 [re-worked] New ldisc for WiLink7.0 pavan_savoy
2010-03-22 21:19 ` [PATCH 1/6] serial: TTY: new ldisc for TI BT/FM/GPS chips pavan_savoy
2010-03-22 21:19   ` [PATCH 2/6] drivers:misc: Kconfig, Makefile for TI's ST ldisc pavan_savoy
2010-03-22 21:19     ` [PATCH 3/6] drivers:misc: sources for ST core pavan_savoy
2010-03-22 21:34       ` Greg KH
2010-03-23 15:24       ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100323202821.22f7c7f0@lxorguk.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavan_savoy@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®