mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] FDPIC: For-loop in elf_core_vma_data_size() is incorrect
@ 2010-03-24 17:02 David Howells
  0 siblings, 0 replies; only message in thread
From: David Howells @ 2010-03-24 17:02 UTC (permalink / raw)
  To: torvalds, akpm, d.hatayama; +Cc: linux-kernel, David Howells

Fix an incorrect for-loop in elf_core_vma_data_size().  The advance-pointer
statement lacks an assignment:

	  CC      fs/binfmt_elf_fdpic.o
	fs/binfmt_elf_fdpic.c: In function 'elf_core_vma_data_size':
	fs/binfmt_elf_fdpic.c:1593: warning: statement with no effect

Signed-off-by: David Howells <dhowells@redhat.com>
---

 fs/binfmt_elf_fdpic.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/fs/binfmt_elf_fdpic.c b/fs/binfmt_elf_fdpic.c
index 2c32d00..7ab23e0 100644
--- a/fs/binfmt_elf_fdpic.c
+++ b/fs/binfmt_elf_fdpic.c
@@ -1590,7 +1590,7 @@ static size_t elf_core_vma_data_size(unsigned long mm_flags)
 	struct vm_area_struct *vma;
 	size_t size = 0;
 
-	for (vma = current->mm->mmap; vma; vma->vm_next)
+	for (vma = current->mm->mmap; vma; vma = vma->vm_next)
 		if (maydump(vma, mm_flags))
 			size += vma->vm_end - vma->vm_start;
 	return size;


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-03-24 17:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-24 17:02 [PATCH] FDPIC: For-loop in elf_core_vma_data_size() is incorrect David Howells

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®