[PATCH] /fs/cifs HEAD

[PATCH] /fs/cifs HEAD

[Timo Witte]

commit 4baf102b1db4ba5c91532acf84acdb9c31867fe6
Author: Timo Witte <timo.witte@googlemail.com>
Date:   Mon Mar 29 10:20:09 2010 +0200
    added additional info to error message in cifs
diff --git a/fs/cifs/dns_resolve.c b/fs/cifs/dns_resolve.c
index 8794814..28b588c 100644
--- a/fs/cifs/dns_resolve.c
+++ b/fs/cifs/dns_resolve.c
@@ -137,7 +137,7 @@ dns_resolve_server_name_to_ip(const char *unc,
char **ip_addr)
                len = rkey->type_data.x[0];
                data = rkey->payload.data;
        } else {
-               cERROR(1, ("%s: unable to resolve: %s", __func__, name));
+              cERROR(1, ("%s: unable to resolve: %s have you
installed /sbin/request-key ?", __func__, name));
                goto out;
        }

Re: [PATCH] /fs/cifs HEAD

[Andrew Morton]

On Mon, 29 Mar 2010 10:39:12 +0200
Timo Witte <timo.witte@googlemail.com> wrote:

> commit 4baf102b1db4ba5c91532acf84acdb9c31867fe6
> Author: Timo Witte <timo.witte@googlemail.com>
> Date: __ Mon Mar 29 10:20:09 2010 +0200
> ____ __added additional info to error message in cifs
> diff --git a/fs/cifs/dns_resolve.c b/fs/cifs/dns_resolve.c
> index 8794814..28b588c 100644
> --- a/fs/cifs/dns_resolve.c
> +++ b/fs/cifs/dns_resolve.c
> @@ -137,7 +137,7 @@ dns_resolve_server_name_to_ip(const char *unc,
> char **ip_addr)
>        len = rkey->type_data.x[0];
>        data = rkey->payload.data;
>    } else {
> -        cERROR(1, ("%s: unable to resolve: %s", func, name));
> +       cERROR(1, ("%s: unable to resolve: %s have you
> installed /sbin/request-key ?", func, name));
>        goto out;
>    }

OK, I can see how that would save someone a lot of time.


Your patch did basically everything wrong: meaningless title,
wordwrapped, changelog doesn't explain the reason for making the patch,
missing Signed-off-by:, didn't cc: the maintainer, gmail-inserted
non-ascii chanracters, tabs replaced by spaces (gmail again).

I typed it in again ;)


Subject: cifs: provide user with a hint when name resolution fails

From: Timo Witte <timo.witte@googlemail.com>

Cc: Steve French <sfrench@samba.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 fs/cifs/dns_resolve.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff -puN fs/cifs/dns_resolve.c~cifs-provide-user-with-a-hint-when-name-resolution-fails fs/cifs/dns_resolve.c
--- a/fs/cifs/dns_resolve.c~cifs-provide-user-with-a-hint-when-name-resolution-fails
+++ a/fs/cifs/dns_resolve.c
@@ -138,7 +138,8 @@ dns_resolve_server_name_to_ip(const char
 		len = rkey->type_data.x[0];
 		data = rkey->payload.data;
 	} else {
-		cERROR(1, ("%s: unable to resolve: %s", __func__, name));
+		cERROR(1, ("%s: unable to resolve: %s have you "
+			"installed /sbin/request-key ?", __func__, name));
 		goto out;
 	}
 
_

Re: [PATCH] /fs/cifs HEAD

[Joe Perches]

On Thu, 1 Apr 2010, Andrew Morton wrote:
> -		cERROR(1, ("%s: unable to resolve: %s", __func__, name));
> +		cERROR(1, ("%s: unable to resolve: %s have you "
> +			"installed /sbin/request-key ?", __func__, name));

It might be better as a single line, but given the desire to break
it up for 80 colums, maybe make it a bit more grammatically correct too:

		cERROR(1, ("%s: unable to resolve: '%s'.  "
			   "Have you installed /sbin/request-key?",
			   __func__, name));