From: Wim Van Sebroeck <wim@iguana.be>
To: Luuk Paulussen <luuk.paulussen@alliedtelesis.co.nz>
Cc: Wim Van Sebroeck <wim@iguana.be>,
Chris Friesen <cfriesen@nortel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fixed book E watchdog period register mask.
Date: Thu, 15 Apr 2010 07:57:15 +0200 [thread overview]
Message-ID: <20100415055715.GD15728@infomag.iguana.be> (raw)
In-Reply-To: <u2l7dc909981004142059p9a453a0gf761e496a65a77d3@mail.gmail.com>
Hi Luuk,
will add this one today or tomorrow, when I finished translating an audit report.
Kind regards,
Wim.
> A previous fix changed the WDTP function to use the period directly,
> rather than subtracting from 63. However the mask generation was
> not changed, so the mask was coming out as 0. This patch fixes it.
>
> Signed-off-by: Luuk Paulussen <luuk.paulussen@alliedtelesis.co.nz>
> ---
> drivers/watchdog/booke_wdt.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/watchdog/booke_wdt.c b/drivers/watchdog/booke_wdt.c
> index 8b724aa..500d383 100644
> --- a/drivers/watchdog/booke_wdt.c
> +++ b/drivers/watchdog/booke_wdt.c
> @@ -44,7 +44,7 @@ u32 booke_wdt_period = WDT_PERIOD_DEFAULT;
>
> #ifdef CONFIG_FSL_BOOKE
> #define WDTP(x) ((((x)&0x3)<<30)|(((x)&0x3c)<<15))
> -#define WDTP_MASK (WDTP(0))
> +#define WDTP_MASK (WDTP(0x3f))
> #else
> #define WDTP(x) (TCR_WP(x))
> #define WDTP_MASK (TCR_WP_MASK)
> --
> 1.6.3.4
prev parent reply other threads:[~2010-04-15 5:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-15 3:59 Luuk Paulussen
2010-04-15 5:57 ` Wim Van Sebroeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100415055715.GD15728@infomag.iguana.be \
--to=wim@iguana.be \
--cc=akpm@linux-foundation.org \
--cc=cfriesen@nortel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luuk.paulussen@alliedtelesis.co.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®