* [PATCH] fixed book E watchdog period register mask.
@ 2010-04-15 3:59 Luuk Paulussen
2010-04-15 5:57 ` Wim Van Sebroeck
0 siblings, 1 reply; 2+ messages in thread
From: Luuk Paulussen @ 2010-04-15 3:59 UTC (permalink / raw)
To: Wim Van Sebroeck
Cc: Chris Friesen, Andrew Morton, Luuk Paulussen, linux-kernel
A previous fix changed the WDTP function to use the period directly,
rather than subtracting from 63. However the mask generation was
not changed, so the mask was coming out as 0. This patch fixes it.
Signed-off-by: Luuk Paulussen <luuk.paulussen@alliedtelesis.co.nz>
---
drivers/watchdog/booke_wdt.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/watchdog/booke_wdt.c b/drivers/watchdog/booke_wdt.c
index 8b724aa..500d383 100644
--- a/drivers/watchdog/booke_wdt.c
+++ b/drivers/watchdog/booke_wdt.c
@@ -44,7 +44,7 @@ u32 booke_wdt_period = WDT_PERIOD_DEFAULT;
#ifdef CONFIG_FSL_BOOKE
#define WDTP(x) ((((x)&0x3)<<30)|(((x)&0x3c)<<15))
-#define WDTP_MASK (WDTP(0))
+#define WDTP_MASK (WDTP(0x3f))
#else
#define WDTP(x) (TCR_WP(x))
#define WDTP_MASK (TCR_WP_MASK)
--
1.6.3.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] fixed book E watchdog period register mask.
2010-04-15 3:59 [PATCH] fixed book E watchdog period register mask Luuk Paulussen
@ 2010-04-15 5:57 ` Wim Van Sebroeck
0 siblings, 0 replies; 2+ messages in thread
From: Wim Van Sebroeck @ 2010-04-15 5:57 UTC (permalink / raw)
To: Luuk Paulussen
Cc: Wim Van Sebroeck, Chris Friesen, Andrew Morton, linux-kernel
Hi Luuk,
will add this one today or tomorrow, when I finished translating an audit report.
Kind regards,
Wim.
> A previous fix changed the WDTP function to use the period directly,
> rather than subtracting from 63. However the mask generation was
> not changed, so the mask was coming out as 0. This patch fixes it.
>
> Signed-off-by: Luuk Paulussen <luuk.paulussen@alliedtelesis.co.nz>
> ---
> drivers/watchdog/booke_wdt.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/watchdog/booke_wdt.c b/drivers/watchdog/booke_wdt.c
> index 8b724aa..500d383 100644
> --- a/drivers/watchdog/booke_wdt.c
> +++ b/drivers/watchdog/booke_wdt.c
> @@ -44,7 +44,7 @@ u32 booke_wdt_period = WDT_PERIOD_DEFAULT;
>
> #ifdef CONFIG_FSL_BOOKE
> #define WDTP(x) ((((x)&0x3)<<30)|(((x)&0x3c)<<15))
> -#define WDTP_MASK (WDTP(0))
> +#define WDTP_MASK (WDTP(0x3f))
> #else
> #define WDTP(x) (TCR_WP(x))
> #define WDTP_MASK (TCR_WP_MASK)
> --
> 1.6.3.4
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-15 5:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-04-15 3:59 [PATCH] fixed book E watchdog period register mask Luuk Paulussen
2010-04-15 5:57 ` Wim Van Sebroeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®