From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Takashi Iwai <tiwai@suse.de>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] input: Add LED support to Synaptics device
Date: Thu, 15 Apr 2010 22:29:44 -0700 [thread overview]
Message-ID: <20100416052944.GB1078@core.coreip.homeip.net> (raw)
In-Reply-To: <20100415191217.GA1495@ucw.cz>
On Thu, Apr 15, 2010 at 09:12:18PM +0200, Pavel Machek wrote:
> Hi!
>
> > The new Synaptics devices have an LED on the top-left corner.
> > This is controlled via the command 0x0a with parameters 0x88 or 0x10.
> >
> > The detection of the LED isn't clear yet. It should have been the new
> > capability bits that indicate the presence, but on real machines, it
> > doesn't fit. So, for the time being, the driver checks the product id
> > in the ext capability bits and assumes that LED exists on the known
> > devices.
> >
> > The support of LED is controlled via a normal input event with EV_LED
> > bit mask. It supports LED_MUTE bit. X driver can detect the LED
> > support by checking these bits.
>
> Could we use generic LED API for this? It is not really 'mute' led
> after all...
Yep, LED_MUTE is not for "muting" touchpads.
--
Dmitry
next prev parent reply other threads:[~2010-04-16 5:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-14 15:10 [PATCH 0/2] Synaptics Clickpad support Takashi Iwai
2010-04-14 15:10 ` [PATCH 1/2] input: Add support of Synaptics Clickpad device Takashi Iwai
2010-04-19 8:32 ` Dmitry Torokhov
2010-04-19 10:29 ` Takashi Iwai
2010-04-21 5:44 ` Dmitry Torokhov
2010-04-21 6:32 ` Takashi Iwai
2010-04-14 15:10 ` [PATCH 2/2] input: Add LED support to Synaptics device Takashi Iwai
2010-04-15 19:12 ` Pavel Machek
2010-04-16 5:29 ` Dmitry Torokhov [this message]
2010-04-16 8:00 ` Takashi Iwai
2010-04-19 10:44 ` Takashi Iwai
2010-04-21 5:43 ` Dmitry Torokhov
2010-04-21 6:31 ` Takashi Iwai
2010-04-21 6:39 ` Dmitry Torokhov
2010-04-21 7:15 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100416052944.GB1078@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®