[PATCH] acecad: fix incorrect size parameter in usb_buffer_free

[PATCH] acecad: fix incorrect size parameter in usb_buffer_free

[Axel Lin]

The size allocated by usb_buffer_alloc is 8, however the size free by
usb_buffer_free in usb_acecad_disconnect is 10.
This patch corrects the size parameter in usb_buffer_free.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Cc: Dmitry Torokhov <dtor@mail.ru>
Cc: Greg KH <gregkh@suse.de>
---
 drivers/input/tablet/acecad.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/input/tablet/acecad.c b/drivers/input/tablet/acecad.c
index 670c61c..265753c 100644
--- a/drivers/input/tablet/acecad.c
+++ b/drivers/input/tablet/acecad.c
@@ -256,7 +256,7 @@ static void usb_acecad_disconnect(struct
usb_interface *intf)
 		usb_kill_urb(acecad->irq);
 		input_unregister_device(acecad->input);
 		usb_free_urb(acecad->irq);
-		usb_buffer_free(interface_to_usbdev(intf), 10, acecad->data,
acecad->data_dma);
+		usb_buffer_free(interface_to_usbdev(intf), 8, acecad->data,
acecad->data_dma);
 		kfree(acecad);
 	}
 }
-- 
1.5.4.3

Re: [PATCH] acecad: fix incorrect size parameter in usb_buffer_free

[Dmitry Torokhov]

Hi Axel,

On Wed, Apr 21, 2010 at 09:07:14AM +0800, Axel Lin wrote:
> The size allocated by usb_buffer_alloc is 8, however the size free by
> usb_buffer_free in usb_acecad_disconnect is 10.
> This patch corrects the size parameter in usb_buffer_free.
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> Cc: Dmitry Torokhov <dtor@mail.ru>
> Cc: Greg KH <gregkh@suse.de>

Will apply both patches to 'next' (while size is wrong 8 and 10 still fall
in the same bucket so there shoudl not be any adverse effects apparent
to users).

You don't actually have the hardware by any chance?

-- 
Dmitry

P.S. Your mailer line-wraps patches so they have to be edited by hand
before applying, please look into it.