From: Arnd Bergmann <arnd@arndb.de>
To: Alessio Igor Bogani <abogani@texware.it>
Cc: Oliver Neukum <oneukum@suse.de>,
"Greg Kroah-Hartman" <gregkh@suse.de>,
Thomas Winischhofer <thomas@winischhofer.net>,
Mauro Carvalho Chehab <mchehab@redhat.com>,
Pete Zaitcev <zaitcev@redhat.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
"Fr??d??ric Weisbecker" <fweisbec@gmail.com>
Subject: Re: [PATCH] USB: sisusbvga: Remove the BKL from open
Date: Mon, 26 Apr 2010 15:15:56 +0200 [thread overview]
Message-ID: <201004261515.56750.arnd@arndb.de> (raw)
In-Reply-To: <h2i63a49ef41004260530x49db3ddczf43423aa49f3b9e1@mail.gmail.com>
On Monday 26 April 2010, Alessio Igor Bogani wrote:
> 2010/4/26 Oliver Neukum <oneukum@suse.de>:
> > Am Sonntag, 25. April 2010 12:37:10 schrieb Alessio Igor Bogani:
> >> BKL is not needed here because necessary locking is already provided
> >> by mutex sisusb->lock.
> >
> > Have you checked the fb layer doesn't need it?
>
> The _open and _release functions are already serialized with mutex in
> fb layer. So that mutex could be removed but in my opinion this job
> should be done in a separate patch (like I have done some time ago for
> nvidiafb driver). Now I would want suggest to remove BKL here only.
What about the BKL in the sisusb_ioctl()? It seems to follow the
same logic, so I would think that you can simply remove the BKL
from the module entirely, rather than only half of it.
Arnd
next prev parent reply other threads:[~2010-04-26 13:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-25 10:37 Alessio Igor Bogani
2010-04-26 12:06 ` Oliver Neukum
2010-04-26 12:30 ` Alessio Igor Bogani
2010-04-26 13:15 ` Arnd Bergmann [this message]
2010-04-26 13:30 ` Alessio Igor Bogani
2010-04-26 13:50 ` Arnd Bergmann
2010-04-26 14:09 ` Alessio Igor Bogani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004261515.56750.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=abogani@texware.it \
--cc=fweisbec@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=oneukum@suse.de \
--cc=thomas@winischhofer.net \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®