From: Alessio Igor Bogani <abogani@texware.it>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Oliver Neukum <oneukum@suse.de>,
Greg Kroah-Hartman <gregkh@suse.de>,
Thomas Winischhofer <thomas@winischhofer.net>,
Mauro Carvalho Chehab <mchehab@redhat.com>,
Pete Zaitcev <zaitcev@redhat.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
"Fr??d??ric Weisbecker" <fweisbec@gmail.com>
Subject: Re: [PATCH] USB: sisusbvga: Remove the BKL from open
Date: Mon, 26 Apr 2010 15:30:34 +0200 [thread overview]
Message-ID: <w2t63a49ef41004260630o31d81ff0qd98cfdace7e73ce0@mail.gmail.com> (raw)
In-Reply-To: <201004261515.56750.arnd@arndb.de>
Dear Mr. Bergmann,
2010/4/26 Arnd Bergmann <arnd@arndb.de>:
>> >> BKL is not needed here because necessary locking is already provided
>> >> by mutex sisusb->lock.
[...]
> What about the BKL in the sisusb_ioctl()? It seems to follow the
> same logic, so I would think that you can simply remove the BKL
> from the module entirely, rather than only half of it.
It is what effectively I'm trying to do!
The first part of this work is already present in USB subsystem
maintainer tree (aka greg) at:
http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/usb/usb-sisusbvga-remove-the-bkl-from-ioctl.patch
Ciao,
Alessio
next prev parent reply other threads:[~2010-04-26 13:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-25 10:37 Alessio Igor Bogani
2010-04-26 12:06 ` Oliver Neukum
2010-04-26 12:30 ` Alessio Igor Bogani
2010-04-26 13:15 ` Arnd Bergmann
2010-04-26 13:30 ` Alessio Igor Bogani [this message]
2010-04-26 13:50 ` Arnd Bergmann
2010-04-26 14:09 ` Alessio Igor Bogani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=w2t63a49ef41004260630o31d81ff0qd98cfdace7e73ce0@mail.gmail.com \
--to=abogani@texware.it \
--cc=arnd@arndb.de \
--cc=fweisbec@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=oneukum@suse.de \
--cc=thomas@winischhofer.net \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®