From: Andi Kleen <andi@firstfloor.org>
To: TAMUKI Shoichi <tamuki@linet.gr.jp>
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Anton Blanchard <anton@samba.org>,
Andi Kleen <andi@firstfloor.org>, Andy Green <andy@warmcat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] panic: keep blinking in spite of long spin timer mode
Date: Fri, 28 May 2010 11:13:54 +0200 [thread overview]
Message-ID: <20100528091354.GA16587@basil.fritz.box> (raw)
In-Reply-To: <201005272156.AA00412@tamuki.linet.gr.jp>
On Fri, May 28, 2010 at 06:56:45AM +0900, TAMUKI Shoichi wrote:
> To keep panic_timeout accuracy when running under a hypervisor, the
> current implementation only spins on long time (1 second) calls to
> mdelay. That brings a good effect, but we must give up blinking even
> if we have a panic_blink.
>
> This patch keeps blinking in spite of long spin timer mode.
>
> We now have new kernel parameter (panic_longspin) to enable long spin
> timer mode when kernel panics. This is to be used when running under
> a hypervisor (default is disable).
Sorry I didn't understand the problem based on your description.
What exactly is the problem with the current code under your
hypervisor?
New parameters for this are probably not the right answer,
who would figure out when to set them.
-Andi
next prev parent reply other threads:[~2010-05-28 9:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-27 21:56 TAMUKI Shoichi
2010-05-28 9:13 ` Andi Kleen [this message]
2010-05-28 22:11 ` TAMUKI Shoichi
2010-05-30 6:55 ` Andi Kleen
2010-06-02 21:57 ` TAMUKI Shoichi
2010-05-28 22:22 ` Randy Dunlap
2010-05-30 21:58 ` TAMUKI Shoichi
2010-06-02 18:34 ` Andrew Morton
2010-06-03 21:49 ` TAMUKI Shoichi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100528091354.GA16587@basil.fritz.box \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=andy@warmcat.com \
--cc=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tamuki@linet.gr.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome