mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: TAMUKI Shoichi <tamuki@linet.gr.jp>
To: Andi Kleen <andi@firstfloor.org>
Cc: Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Anton Blanchard <anton@samba.org>, Andy Green <andy@warmcat.com>,
	TAMUKI Shoichi <tamuki@linet.gr.jp>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] panic: keep blinking in spite of long spin timer mode
Date: Thu, 03 Jun 2010 06:57:01 +0900	[thread overview]
Message-ID: <201006022157.AA00420@tamuki.linet.gr.jp> (raw)
In-Reply-To: <20100530065522.GA14556@basil.fritz.box>

Hello,

Thank you for the suggestion.

On Sun, 30 May 2010 08:55:22 +0200 Andi Kleen wrote:

> Thanks for this explanation, makes all sense.
> But should do these changes by default then, not with a parameter.

Hmm, that will not be acceptable since the control of blinking speed
becomes difficult with long spin timer mode.

However, I agree to your opinion that it is not the best answer to
prepare purposely a new parameter for such a rare situation.

> Changing the frequency is ok, the only requirement is that it is
> visible and different from the frequency kdb uses.

So, I changed that the time calls to mdelay will be automatically
switched to longer if the speed of blinking is slow enough.  The
kernel parameter (panic_longspin) becomes no longer necessary.

I will soon post the PATCH v2.

Regards,
TAMUKI Shoichi

  reply	other threads:[~2010-06-02 21:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-27 21:56 TAMUKI Shoichi
2010-05-28  9:13 ` Andi Kleen
2010-05-28 22:11   ` TAMUKI Shoichi
2010-05-30  6:55     ` Andi Kleen
2010-06-02 21:57       ` TAMUKI Shoichi [this message]
2010-05-28 22:22 ` Randy Dunlap
2010-05-30 21:58   ` TAMUKI Shoichi
2010-06-02 18:34 ` Andrew Morton
2010-06-03 21:49   ` TAMUKI Shoichi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201006022157.AA00420@tamuki.linet.gr.jp \
    --to=tamuki@linet.gr.jp \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=andy@warmcat.com \
    --cc=anton@samba.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®