[PATCH] streamline_config.pl: make a variable local

[PATCH] streamline_config.pl: make a variable local

[Toralf Foerster]

to prevent a possible pitfall

Signed-off-by: Toralf Foerster <toralf.foerster@gmx.de>
---
 scripts/kconfig/streamline_config.pl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/scripts/kconfig/streamline_config.pl b/scripts/kconfig/streamline_config.pl
index afbd54a..9726946 100644
--- a/scripts/kconfig/streamline_config.pl
+++ b/scripts/kconfig/streamline_config.pl
@@ -307,7 +307,7 @@ close (LIN);
 my %configs;
 foreach my $module (keys(%modules)) {
     if (defined($objects{$module})) {
-       @arr = @{$objects{$module}};
+       my @arr = @{$objects{$module}};
        foreach my $conf (@arr) {
            $configs{$conf} = $module;
        }
-- 
1.6.4.4


-- 
MfG/Sincerely
Toralf Foerster

pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3

Re: [PATCH] streamline_config.pl: make a variable local

[Steven Rostedt]

On Fri, 2010-05-28 at 10:24 +0200, Toralf Foerster wrote:
> to prevent a possible pitfall
> 
> Signed-off-by: Toralf Foerster <toralf.foerster@gmx.de>
> ---
>  scripts/kconfig/streamline_config.pl |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/scripts/kconfig/streamline_config.pl b/scripts/kconfig/streamline_config.pl
> index afbd54a..9726946 100644
> --- a/scripts/kconfig/streamline_config.pl
> +++ b/scripts/kconfig/streamline_config.pl
> @@ -307,7 +307,7 @@ close (LIN);
>  my %configs;
>  foreach my $module (keys(%modules)) {
>      if (defined($objects{$module})) {
> -       @arr = @{$objects{$module}};
> +       my @arr = @{$objects{$module}};


Either your mail client, or the method you use to get these into your
mail is causing whitespace issues. There are tabs here that your patch
has converted into spaces, causing the patch to fail to apply.

I've fixed it up, but please fix this before sending more patches.

-- Steve

>         foreach my $conf (@arr) {
>             $configs{$conf} = $module;
>         }
> -- 
> 1.6.4.4
> 
>