From: Stephen Hemminger <shemminger@vyatta.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: floppy driver assumes INITIAL_JIFFIES == 0
Date: Thu, 3 Jun 2010 10:15:01 -0700 [thread overview]
Message-ID: <20100603101501.5e5d7148@nehalam> (raw)
The ancient and crufty floppy driver has some serious problems if
used during the boot process. It will miss data, and cause OOPS
because of callback routines called in unexpected contexts.
All this goes away if INITIAL_JIFFIES is 0 as it was when this
driver was written.
The root cause of all this is lots of places that assume the initial
jiffies value is 0. Examples:
floppy_open:
if (!(mode & FMODE_NDELAY)) {
if (mode & (FMODE_READ|FMODE_WRITE)) {
UDRS->last_checked = 0;
start_motor:
if (!(raw_cmd->flags & FD_RAW_NO_MOTOR)) {
if (!(FDCS->dor & (0x10 << UNIT(current_drive)))) {
set_debugt();
/* no read since this drive is running */
DRS->first_read_date = 0;
and the relationship between select_date and select_delay.
The driver is a complex mess of spaghetti state. Does one of the original
authors have more background to fix this?
next reply other threads:[~2010-06-03 17:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-03 17:15 Stephen Hemminger [this message]
2010-06-03 17:28 ` Linus Torvalds
2010-06-03 19:03 ` Stephen Hemminger
2010-06-03 19:56 ` Linus Torvalds
2010-06-03 20:59 ` Linus Torvalds
2010-06-03 21:49 ` Stephen Hemminger
2010-06-03 21:58 ` Linus Torvalds
2010-06-03 22:33 ` Linus Torvalds
2010-06-03 22:54 ` Stephen Hemminger
2010-06-03 23:09 ` Linus Torvalds
2010-06-03 23:15 ` Stephen Hemminger
2010-06-03 23:21 ` Linus Torvalds
2010-06-09 5:32 ` Stephen Hemminger
2010-06-03 22:32 ` Andreas Mohr
2010-06-03 22:40 ` Linus Torvalds
2010-06-04 15:12 ` Nick Bowler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100603101501.5e5d7148@nehalam \
--to=shemminger@vyatta.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome