From: Greg KH <greg@kroah.com>
To: Michal Nazarewicz <m.nazarewicz@samsung.com>
Cc: linux-usb@vger.kernel.org,
David Brownell <dbrownell@users.sourceforge.net>,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: gadget: g_fs: code cleanup
Date: Fri, 25 Jun 2010 08:27:27 -0700 [thread overview]
Message-ID: <20100625152727.GB11840@kroah.com> (raw)
In-Reply-To: <b51342e058f33dc9d78491c1209d0e86d09ed9db.1276170819.git.m.nazarewicz@samsung.com>
On Fri, Jun 25, 2010 at 04:29:27PM +0200, Michal Nazarewicz wrote:
> This commit cleans the g_fs gadget hopefully making it more
> readable. This is achieved by usage of the usb_string_ids_tab()
> function for batch string IDs registration as well as
> generalising configuration so that a single routine is
> used to add each configuration and bind interfaces. As an
> effect, the code is shorter and has fewer #ifdefs.
>
> Moreover, in some circumstances previous code #defined
> CONFIG_USB_FUNCTIONFS_GENERIC macro to prevent a situation
> where gadget with no configurations is built. This code removes
> the #define form source code and achieves the same effect using
> select in Kconfig.
>
> This patch also changes wording and names of the Kconfig options.
>
> Signed-off-by: Michal Nazarewicz <m.nazarewicz@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> I believe this was overlooked so I am resending this patch again.
Please always cc: me on patches you want applied, otherwise I very
easily overlook them due to the very large amount of email I get.
thanks,
greg k-h
prev parent reply other threads:[~2010-06-25 15:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-25 14:29 Michal Nazarewicz
2010-06-25 15:27 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100625152727.GB11840@kroah.com \
--to=greg@kroah.com \
--cc=dbrownell@users.sourceforge.net \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.nazarewicz@samsung.com \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®