From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Sundar R IYER <sundar.iyer@stericsson.com>
Cc: "lrg@slimlogic.co.uk" <lrg@slimlogic.co.uk>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
STEricsson_nomadik_linux <STEricsson_nomadik_linux@list.st.com>,
Linus WALLEIJ <linus.walleij@stericsson.com>,
Bengt JONSSON <bengt.g.jonsson@stericsson.com>
Subject: Re: [PATCH v2 1/2] regulator: add support for regulators on the ab8500 MFD
Date: Tue, 13 Jul 2010 15:57:28 +0100 [thread overview]
Message-ID: <20100713145727.GB24626@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <33A307AF30D7BF4F811B1568FE7A9B1810E7E880@EXDCVYMBSTM006.EQ1STM.local>
On Tue, Jul 13, 2010 at 04:34:56PM +0200, Sundar R IYER wrote:
> >> + * @mask: mask to enable/disable regulator
> >> + * @enable: bits to enable the regulator in normal(high power) mode
> >Have you addressed my comments here?
> Sorry that I couldn't inline my replies into the patch itself :(. I changed the comments for the variable
> from the previous patch set. But I agree I messed up!
> Yes. The mask here is different for the fact that we have two enable bits; enable LP(low power)
> mode and enable HP(high power). We enable only the HP modes and hence the different mask
> for enable/disable as well as for the enable.
OK.
next prev parent reply other threads:[~2010-07-13 14:57 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-13 14:09 Sundar Iyer
2010-07-13 14:09 ` [PATCH v2 2/2] ux500: add ab8500-regulators machine specific data Sundar Iyer
2010-07-13 14:18 ` Mark Brown
2010-07-13 14:41 ` Sundar R IYER
2010-07-13 14:56 ` Mark Brown
2010-07-13 15:08 ` Sundar R IYER
2010-07-13 15:09 ` Mark Brown
2010-07-13 16:13 ` Sundar R IYER
2010-07-13 20:38 ` Mark Brown
2010-07-14 14:50 ` Sundar R IYER
2010-07-14 14:57 ` Mark Brown
2010-07-14 15:36 ` Sundar R IYER
2010-07-14 15:47 ` Mark Brown
2010-07-14 16:09 ` Sundar R IYER
2010-07-14 16:20 ` Mark Brown
2010-07-14 16:47 ` Sundar R IYER
2010-07-14 17:03 ` Mark Brown
2010-07-14 17:36 ` Sundar R IYER
2010-07-14 18:42 ` Mark Brown
2010-07-14 22:51 ` Linus Walleij
2010-07-15 9:09 ` Mark Brown
2010-07-13 14:17 ` [PATCH v2 1/2] regulator: add support for regulators on the ab8500 MFD Mark Brown
2010-07-13 14:34 ` Sundar R IYER
2010-07-13 14:57 ` Mark Brown [this message]
2010-07-13 14:58 ` Mark Brown
2010-07-13 15:11 ` Sundar R IYER
2010-07-13 15:12 ` Mark Brown
2010-07-13 16:18 ` Sundar R IYER
2010-07-13 20:40 ` Mark Brown
2010-07-15 10:29 ` Liam Girdwood
2010-10-27 16:25 ` Thiago Farina
2010-10-27 17:33 ` Mark Brown
2010-10-27 17:42 ` Thiago Farina
2010-10-27 17:56 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100713145727.GB24626@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=STEricsson_nomadik_linux@list.st.com \
--cc=bengt.g.jonsson@stericsson.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=sameo@linux.intel.com \
--cc=sundar.iyer@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®