* [PATCH 10/11] staging: msm: formatting of pointers in printk()
@ 2010-07-14 18:05 Kulikov Vasiliy
2010-07-14 22:28 ` David Brown
0 siblings, 1 reply; 3+ messages in thread
From: Kulikov Vasiliy @ 2010-07-14 18:05 UTC (permalink / raw)
To: kernel-janitors
Cc: Greg Kroah-Hartman, Daniel Walker, Stepan Moskovchenko,
Abhijeet Dharmapurikar, David Brown, devel, linux-kernel
Use %p instead of %08x in printk().
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
drivers/staging/msm/mdp4_overlay.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/msm/mdp4_overlay.c b/drivers/staging/msm/mdp4_overlay.c
index 304bb82..de284c2 100644
--- a/drivers/staging/msm/mdp4_overlay.c
+++ b/drivers/staging/msm/mdp4_overlay.c
@@ -874,8 +874,8 @@ struct mdp4_overlay_pipe *mdp4_overlay_pipe_alloc(void)
if (pipe->pipe_ndx == 0) {
pipe->pipe_ndx = i + 1; /* start from 1 */
init_completion(&pipe->comp);
- printk(KERN_INFO "mdp4_overlay_pipe_alloc: pipe=%x ndx=%d\n",
- (int)pipe, pipe->pipe_ndx);
+ printk(KERN_INFO "mdp4_overlay_pipe_alloc: pipe=%p ndx=%d\n",
+ pipe, pipe->pipe_ndx);
return pipe;
}
pipe++;
@@ -887,8 +887,8 @@ struct mdp4_overlay_pipe *mdp4_overlay_pipe_alloc(void)
void mdp4_overlay_pipe_free(struct mdp4_overlay_pipe *pipe)
{
- printk(KERN_INFO "mdp4_overlay_pipe_free: pipe=%x ndx=%d\n",
- (int)pipe, pipe->pipe_ndx);
+ printk(KERN_INFO "mdp4_overlay_pipe_free: pipe=%p ndx=%d\n",
+ pipe, pipe->pipe_ndx);
memset(pipe, 0, sizeof(*pipe));
}
--
1.7.0.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 10/11] staging: msm: formatting of pointers in printk()
2010-07-14 18:05 [PATCH 10/11] staging: msm: formatting of pointers in printk() Kulikov Vasiliy
@ 2010-07-14 22:28 ` David Brown
2010-07-14 22:29 ` Daniel Walker
0 siblings, 1 reply; 3+ messages in thread
From: David Brown @ 2010-07-14 22:28 UTC (permalink / raw)
To: Kulikov Vasiliy
Cc: kernel-janitors, Greg Kroah-Hartman, Daniel Walker,
Stepan Moskovchenko, Abhijeet Dharmapurikar, devel, linux-kernel
On Wednesday 14 July 2010 11:05:58 Kulikov Vasiliy wrote:
> Use %p instead of %08x in printk().
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Acked-by: David Brown <davidb@codeaurora.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 10/11] staging: msm: formatting of pointers in printk()
2010-07-14 22:28 ` David Brown
@ 2010-07-14 22:29 ` Daniel Walker
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Walker @ 2010-07-14 22:29 UTC (permalink / raw)
To: David Brown
Cc: Kulikov Vasiliy, kernel-janitors, Greg Kroah-Hartman,
Stepan Moskovchenko, Abhijeet Dharmapurikar, devel, linux-kernel
On Wed, 2010-07-14 at 15:28 -0700, David Brown wrote:
> On Wednesday 14 July 2010 11:05:58 Kulikov Vasiliy wrote:
>
> > Use %p instead of %08x in printk().
> >
> > Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
>
> Acked-by: David Brown <davidb@codeaurora.org>
yeah, it looks fine to me too.
Daniel
--
Sent by an consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-07-14 22:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-07-14 18:05 [PATCH 10/11] staging: msm: formatting of pointers in printk() Kulikov Vasiliy
2010-07-14 22:28 ` David Brown
2010-07-14 22:29 ` Daniel Walker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®