mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: viro@ZenIV.linux.org.uk
Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org,
	linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org,
	linux-kernel@vger.kernel.org, samba-technical@lists.samba.org,
	linux-ext4@vger.kernel.org
Subject: [PATCH 03/18] AFS: Use i_generation not i_version for the vnode uniquifier [ver #6]
Date: Thu, 15 Jul 2010 03:17:13 +0100	[thread overview]
Message-ID: <20100715021713.5544.70044.stgit@warthog.procyon.org.uk> (raw)
In-Reply-To: <20100715021709.5544.64506.stgit@warthog.procyon.org.uk>

Store the AFS vnode uniquifier in the i_generation field, not the i_version
field of the inode struct.  i_version can then be given the AFS data version
number.

Signed-off-by: David Howells <dhowells@redhat.com>
---

 fs/afs/dir.c      |    8 ++++----
 fs/afs/fsclient.c |    3 ++-
 fs/afs/inode.c    |   10 +++++-----
 3 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/fs/afs/dir.c b/fs/afs/dir.c
index b42d5cc..afb9ff8 100644
--- a/fs/afs/dir.c
+++ b/fs/afs/dir.c
@@ -542,11 +542,11 @@ static struct dentry *afs_lookup(struct inode *dir, struct dentry *dentry,
 	dentry->d_op = &afs_fs_dentry_operations;
 
 	d_add(dentry, inode);
-	_leave(" = 0 { vn=%u u=%u } -> { ino=%lu v=%llu }",
+	_leave(" = 0 { vn=%u u=%u } -> { ino=%lu v=%u }",
 	       fid.vnode,
 	       fid.unique,
 	       dentry->d_inode->i_ino,
-	       (unsigned long long)dentry->d_inode->i_version);
+	       dentry->d_inode->i_generation);
 
 	return NULL;
 }
@@ -626,10 +626,10 @@ static int afs_d_revalidate(struct dentry *dentry, struct nameidata *nd)
 		 * been deleted and replaced, and the original vnode ID has
 		 * been reused */
 		if (fid.unique != vnode->fid.unique) {
-			_debug("%s: file deleted (uq %u -> %u I:%llu)",
+			_debug("%s: file deleted (uq %u -> %u I:%u)",
 			       dentry->d_name.name, fid.unique,
 			       vnode->fid.unique,
-			       (unsigned long long)dentry->d_inode->i_version);
+			       dentry->d_inode->i_generation);
 			spin_lock(&vnode->lock);
 			set_bit(AFS_VNODE_DELETED, &vnode->flags);
 			spin_unlock(&vnode->lock);
diff --git a/fs/afs/fsclient.c b/fs/afs/fsclient.c
index 4bd0218..346e328 100644
--- a/fs/afs/fsclient.c
+++ b/fs/afs/fsclient.c
@@ -89,7 +89,7 @@ static void xdr_decode_AFSFetchStatus(const __be32 **_bp,
 			i_size_write(&vnode->vfs_inode, size);
 			vnode->vfs_inode.i_uid = status->owner;
 			vnode->vfs_inode.i_gid = status->group;
-			vnode->vfs_inode.i_version = vnode->fid.unique;
+			vnode->vfs_inode.i_generation = vnode->fid.unique;
 			vnode->vfs_inode.i_nlink = status->nlink;
 
 			mode = vnode->vfs_inode.i_mode;
@@ -102,6 +102,7 @@ static void xdr_decode_AFSFetchStatus(const __be32 **_bp,
 		vnode->vfs_inode.i_ctime.tv_sec	= status->mtime_server;
 		vnode->vfs_inode.i_mtime	= vnode->vfs_inode.i_ctime;
 		vnode->vfs_inode.i_atime	= vnode->vfs_inode.i_ctime;
+		vnode->vfs_inode.i_version	= data_version;
 	}
 
 	expected_version = status->data_version;
diff --git a/fs/afs/inode.c b/fs/afs/inode.c
index d00b312..ee3190a 100644
--- a/fs/afs/inode.c
+++ b/fs/afs/inode.c
@@ -73,7 +73,8 @@ static int afs_inode_map_status(struct afs_vnode *vnode, struct key *key)
 	inode->i_ctime.tv_nsec	= 0;
 	inode->i_atime		= inode->i_mtime = inode->i_ctime;
 	inode->i_blocks		= 0;
-	inode->i_version	= vnode->fid.unique;
+	inode->i_generation	= vnode->fid.unique;
+	inode->i_version	= vnode->status.data_version;
 	inode->i_mapping->a_ops	= &afs_fs_aops;
 
 	/* check to see whether a symbolic link is really a mountpoint */
@@ -98,7 +99,7 @@ static int afs_iget5_test(struct inode *inode, void *opaque)
 	struct afs_iget_data *data = opaque;
 
 	return inode->i_ino == data->fid.vnode &&
-		inode->i_version == data->fid.unique;
+		inode->i_generation == data->fid.unique;
 }
 
 /*
@@ -110,7 +111,7 @@ static int afs_iget5_set(struct inode *inode, void *opaque)
 	struct afs_vnode *vnode = AFS_FS_I(inode);
 
 	inode->i_ino = data->fid.vnode;
-	inode->i_version = data->fid.unique;
+	inode->i_generation = data->fid.unique;
 	vnode->fid = data->fid;
 	vnode->volume = data->volume;
 
@@ -306,8 +307,7 @@ int afs_getattr(struct vfsmount *mnt, struct dentry *dentry,
 
 	inode = dentry->d_inode;
 
-	_enter("{ ino=%lu v=%llu }", inode->i_ino,
-		(unsigned long long)inode->i_version);
+	_enter("{ ino=%lu v=%u }", inode->i_ino, inode->i_generation);
 
 	generic_fillattr(inode, stat);
 	return 0;


  parent reply	other threads:[~2010-07-15  2:17 UTC|newest]

Thread overview: 132+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-15  2:17 [PATCH 00/18] Extended file stat functions " David Howells
2010-07-15  2:17 ` [PATCH 01/18] Mark arguments to certain syscalls as being const " David Howells
2010-07-15  2:17 ` [PATCH 02/18] xstat: Add a pair of system calls to make extended file stats available " David Howells
2010-07-15 20:35   ` Arnd Bergmann
2010-07-15 21:53   ` David Howells
2010-07-16  6:22     ` Mark Harris
2010-07-16 10:24     ` David Howells
2010-07-16 11:02       ` Arnd Bergmann
2010-07-16 12:38       ` David Howells
2010-07-16 13:32         ` Arnd Bergmann
2010-07-17  5:51         ` Mark Harris
2010-07-17  9:00           ` Arnd Bergmann
2010-07-17  9:49         ` David Howells
2010-07-16 10:46     ` Arnd Bergmann
2010-07-16 15:10     ` David Howells
2010-07-18  8:48   ` Christoph Hellwig
2010-07-22 10:52     ` Jan Engelhardt
2010-07-22 12:25     ` David Howells
2010-07-19 14:05   ` David Howells
2010-07-19 15:17   ` Linus Torvalds
2010-07-19 16:15   ` David Howells
2010-07-19 16:51     ` Linus Torvalds
2010-07-19 17:26     ` David Howells
2010-07-19 17:46       ` Linus Torvalds
2010-07-20  8:28         ` Andreas Dilger
2010-07-22 10:35   ` Jan Engelhardt
2010-07-22 12:14   ` David Howells
2010-07-22 12:17     ` Volker Lendecke
2010-07-22 13:05       ` Jan Engelhardt
2010-07-22 15:14       ` Linus Torvalds
2010-07-22 15:36         ` Volker Lendecke
2010-07-22 15:47           ` Linus Torvalds
2010-07-22 16:06             ` Greg Freemyer
2010-07-22 16:07               ` Greg Freemyer
2010-07-22 16:25             ` Jan Engelhardt
2010-07-22 16:27             ` Jeremy Allison
2010-07-22 16:40               ` Linus Torvalds
2010-07-22 16:58                 ` Trond Myklebust
2010-07-22 18:02                   ` Jeremy Allison
2010-07-22 18:04                     ` Volker Lendecke
2010-07-22 18:07                       ` Jeremy Allison
2010-07-22 18:59                       ` Trond Myklebust
2010-07-30 17:55                         ` Phil Pishioneri
2010-07-30 18:11                           ` Trond Myklebust
2010-07-30 18:19                             ` Phil Pishioneri
2010-07-31 18:41                             ` Andreas Dilger
2010-07-31 18:48                               ` Jan Engelhardt
2010-07-31 19:03                               ` Trond Myklebust
2010-07-31 21:20                                 ` Jan Engelhardt
2010-08-01 13:17                             ` Jeff Layton
2010-07-22 18:05                     ` Jan Engelhardt
2010-07-22 18:07                       ` Jeremy Allison
2010-07-22 19:18                     ` John Stoffel
2010-07-22 17:03                 ` Jan Engelhardt
2010-07-22 17:16                   ` Trond Myklebust
2010-07-22 17:36                     ` Jan Engelhardt
2010-07-22 17:24                   ` Linus Torvalds
2010-07-22 18:15                     ` Jeremy Allison
2010-07-22 18:21                     ` Benny Halevy
2010-07-22 18:45                       ` Greg Freemyer
2010-07-22 19:53                         ` Benny Halevy
2010-07-22 18:41                     ` Greg Freemyer
2010-07-28  1:15                     ` Neil Brown
2010-07-28 17:28                     ` David Howells
2010-07-28 23:04                       ` Neil Brown
2010-07-30 18:38                         ` J. Bruce Fields
2010-08-01 13:40                         ` Jeff Layton
2010-08-02 14:09                           ` Greg Freemyer
2010-08-02 14:42                             ` Jeff Layton
2010-07-29 16:15                       ` David Howells
2010-08-03  1:13                         ` Neil Brown
2010-07-22 17:12                 ` Jim Rees
2010-07-22 17:32                   ` Linus Torvalds
2010-07-23  1:03                 ` tridge
2010-07-23  1:21                   ` Ted Ts'o
2010-07-23  2:12                     ` tridge
2010-07-23  9:14                     ` Björn Jacke
2010-07-30 21:22                 ` utz lehmann
2010-07-31  8:08                   ` Jan Engelhardt
2010-07-31 14:43                     ` utz lehmann
2010-08-01 13:25                   ` Jeff Layton
2010-08-05 23:52                     ` Jeremy Allison
2010-08-06  3:38                       ` Neil Brown
2010-08-06  3:55                         ` Steve French
2010-08-06 11:18                           ` Jeff Layton
2010-08-06 23:30                           ` Neil Brown
2010-08-06 23:58                             ` Steve French
2010-08-07  0:29                               ` Neil Brown
2010-08-07  2:42                                 ` Steve French
2010-08-07  2:54                                   ` Steve French
2010-08-07  3:32                                     ` Neil Brown
2010-08-07 10:34                                       ` Jeff Layton
2010-08-07 11:04                                         ` Neil Brown
2010-08-08 12:12                         ` Jeremy Allison
2010-08-08 12:53                           ` Jeff Layton
2010-08-08 13:05                             ` Jeremy Allison
2010-08-13 12:54                               ` J. Bruce Fields
2010-08-13 17:54                                 ` Jeremy Allison
2010-08-13 18:09                                   ` Steve French
2010-08-13 19:06                                   ` Jan Engelhardt
2010-08-13 19:19                                     ` Jeremy Allison
2010-08-16 18:04                                       ` J. Bruce Fields
2010-08-16 18:08                                   ` J. Bruce Fields
2010-08-16 19:07                                     ` Jeremy Allison
2010-08-08 23:07                           ` Neil Brown
2010-07-22 15:46         ` Jan Engelhardt
2010-07-22 16:06         ` David Howells
     [not found]       ` <AANLkTikBCXK6uEw <AANLkTimdFCGSKLn7aGMpBMIauHTsHY7hpAAmpo6uTcnD@mail.gmail.com>
2010-07-31 16:53         ` David Howells
2010-07-31 18:05           ` utz lehmann
2010-07-31 19:26           ` David Howells
2010-07-15  2:17 ` David Howells [this message]
2010-07-15  2:17 ` [PATCH 04/18] xstat: AFS: Return extended attributes " David Howells
2010-07-15  2:17 ` [PATCH 05/18] xstat: eCryptFS: " David Howells
2010-07-15  2:17 ` [PATCH 06/18] xstat: Ext4: " David Howells
2010-07-15  2:17 ` [PATCH 07/18] xstat: NFS: " David Howells
2010-07-15  2:17 ` [PATCH 08/18] xstat: CIFS: " David Howells
2010-07-15  2:17 ` [PATCH 09/18] xstat: Make special system filesystems return FS_SPECIAL_FL " David Howells
2010-07-18  8:49   ` Christoph Hellwig
2010-07-19 14:09   ` David Howells
2010-07-27 13:41   ` David Howells
2010-07-15  2:17 ` [PATCH 10/18] xstat: Make network filesystems return FS_REMOTE_FL " David Howells
2010-07-15  2:17 ` [PATCH 11/18] xstat: Make automounter filesystems return FS_AUTOMOUNT_FL " David Howells
2010-07-15  2:17 ` [PATCH 12/18] xstat: Add a dentry op to handle automounting rather than abusing follow_link() " David Howells
2010-07-18  8:50   ` Christoph Hellwig
2010-07-19 14:10   ` David Howells
2010-07-15  2:17 ` [PATCH 13/18] xstat: AFS: Use d_automount() " David Howells
2010-07-15  2:17 ` [PATCH 14/18] xstat: NFS: " David Howells
2010-07-15  2:17 ` [PATCH 15/18] xstat: CIFS: " David Howells
2010-07-15  2:17 ` [PATCH 16/18] xstat: Remove the automount through follow_link() kludge code from pathwalk " David Howells
2010-07-15  2:17 ` [PATCH 17/18] xstat: Add an AT_NO_AUTOMOUNT flag to suppress terminal automount " David Howells
2010-07-15  2:17 ` [PATCH 18/18] xstat: Provide a mechanism to gather extra results for [f]xstat() " David Howells
2010-07-18  8:51   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100715021713.5544.70044.stgit@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=samba-technical@lists.samba.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome