From: Randy Dunlap <rdunlap@xenotime.net>
To: Krzysztof Halasa <khc@pm.waw.pl>
Cc: Dimitrios Apostolou <jimis@gmx.net>,
linux-kernel@vger.kernel.org, Dan Nicolaescu <dann@gnu.org>
Subject: Re: emacs and "linux" coding style
Date: Sat, 17 Jul 2010 06:51:46 -0700 [thread overview]
Message-ID: <20100717065146.732f5449.rdunlap@xenotime.net> (raw)
In-Reply-To: <m3tyny31mo.fsf@intrepid.localdomain>
On Sat, 17 Jul 2010 11:21:03 +0200 Krzysztof Halasa wrote:
> Dimitrios Apostolou <jimis@gmx.net> writes:
>
> > static void update_group_shares_cpu(struct task_group *tg, int cpu,
> > unsigned long sd_shares,
> > unsigned long sd_rq_weight,
> > unsigned long *usd_rq_weight)
> > {
>
> From a technical POV the above should not have any tabs, the parameters
> should be aligned with spaces only.
fwiw, it seems that you agree with Ted.
> The tabs should be used for (syntactic) indentation only.
>
> This way we can display the code correctly with any tab length.
but we know what the tab length is. ;)
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2010-07-17 13:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-13 14:00 Dimitrios Apostolou
2010-07-13 22:19 ` Randy Dunlap
2010-07-14 6:12 ` Theodore Tso
2010-07-15 11:46 ` Dimitrios Apostolou
2010-07-17 9:21 ` Krzysztof Halasa
2010-07-17 13:51 ` Randy Dunlap [this message]
2010-07-17 23:18 ` Krzysztof Halasa
2010-07-18 7:15 ` Ted Ts'o
2010-07-18 9:05 ` Krzysztof Halasa
2010-07-18 9:10 ` Dimitrios Apostolou
2010-07-18 9:21 ` Ted Ts'o
2010-07-18 21:53 ` Krzysztof Halasa
2010-07-18 9:37 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100717065146.732f5449.rdunlap@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=dann@gnu.org \
--cc=jimis@gmx.net \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®