From: Dimitrios Apostolou <jimis@gmx.net>
To: Theodore Tso <tytso@MIT.EDU>
Cc: Randy Dunlap <rdunlap@xenotime.net>,
linux-kernel@vger.kernel.org, Dan Nicolaescu <dann@gnu.org>,
Teemu Likonen <tlikonen@iki.fi>
Subject: Re: emacs and "linux" coding style
Date: Thu, 15 Jul 2010 14:46:48 +0300 (EEST) [thread overview]
Message-ID: <alpine.LNX.2.00.1007151432460.1500@localhost.localdomain> (raw)
In-Reply-To: <0A4C5074-D482-42EE-98D1-93C636BC80B8@mit.edu>
Hi,
On Wed, 14 Jul 2010, Theodore Tso wrote:
> I've always read indentation as referring to indentation for the beginning of
> code lines, but not to making function parameters or paraenthesis line
> up. This is something which emacs does automatically, but vi does not.
>
> People who are anal enough to worry about this sort of thing, in general,
> IMHO, really should find better things to do. And if checkpatch.pl were to
> be "improved" to start issue warnings about code not adhering to this
> CodingStyle assertion, #1, you would find out how much code doesn't
> adhere to this, and #2, I think a lot of people, including myself, would be
> complaining vociferously and agitating to have that language removed
> from CodingStyle as being an actively harmful and incorrect recommendation.
if two kernel developers agree that tabs-only alignment of arglists is not
necessary, then my guess is that the CodingStyle document is broken and
needs to be fixed. Quote from Documentation/CodingStyle:
That's OK, we all do. You've probably been told by your long-time
Unix user helper that "GNU emacs" automatically formats the C sources for
you, and you've noticed that yes, it does do that, but the defaults it
uses are less than desirable (in fact, they are worse than random typing -
an infinite number of monkeys typing into GNU emacs would never make a
good program).
So, you can either get rid of GNU emacs, or change it to use saner
values. To do the latter, you can stick the following in your .emacs
file:
If emacs' style is OK then why all this inflamatory talk is needed, and
why is a patch proposed? The only thing needed is to use the "linux"
c-style.
Thanks,
Dimitris
P.S. CC'd the author of latest emacs-related patch in CodingStyle
next prev parent reply other threads:[~2010-07-15 11:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-13 14:00 Dimitrios Apostolou
2010-07-13 22:19 ` Randy Dunlap
2010-07-14 6:12 ` Theodore Tso
2010-07-15 11:46 ` Dimitrios Apostolou [this message]
2010-07-17 9:21 ` Krzysztof Halasa
2010-07-17 13:51 ` Randy Dunlap
2010-07-17 23:18 ` Krzysztof Halasa
2010-07-18 7:15 ` Ted Ts'o
2010-07-18 9:05 ` Krzysztof Halasa
2010-07-18 9:10 ` Dimitrios Apostolou
2010-07-18 9:21 ` Ted Ts'o
2010-07-18 21:53 ` Krzysztof Halasa
2010-07-18 9:37 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1007151432460.1500@localhost.localdomain \
--to=jimis@gmx.net \
--cc=dann@gnu.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=tlikonen@iki.fi \
--cc=tytso@MIT.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®