From: Suresh Siddha <suresh.b.siddha@intel.com>
To: "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Suresh Siddha <suresh.b.siddha@intel.com>
Subject: [patch 5/5] x86: use xsaveopt in context-switch path when supported
Date: Mon, 19 Jul 2010 16:05:52 -0700 [thread overview]
Message-ID: <20100719230205.604014179@sbs-t61.sc.intel.com> (raw)
In-Reply-To: <20100719225747.372816924@sbs-t61.sc.intel.com>
[-- Attachment #1: xsaveopt_support.patch --]
[-- Type: text/plain, Size: 3351 bytes --]
xsaveopt is a more optimized form of xsave specifically designed
for the context switch usage. xsaveopt doesn't save the state that's not
modified from the prior xrstor. And if a specific feature state gets
modified to the init state, then xsaveopt just updates the header bit
in the xsave memory layout without updating the corresponding memory
layout.
Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
---
arch/x86/include/asm/i387.h | 2 +-
arch/x86/include/asm/xsave.h | 9 ++++++---
arch/x86/kernel/cpu/addon_cpuid_features.c | 1 +
arch/x86/kernel/cpu/common.c | 8 ++++++++
4 files changed, 16 insertions(+), 4 deletions(-)
Index: tip-linux-2.6/arch/x86/include/asm/xsave.h
===================================================================
--- tip-linux-2.6.orig/arch/x86/include/asm/xsave.h
+++ tip-linux-2.6/arch/x86/include/asm/xsave.h
@@ -135,8 +135,11 @@ static inline void fpu_xsave(struct fpu
{
/* This, however, we can work around by forcing the compiler to select
an addressing mode that doesn't require extended registers. */
- __asm__ __volatile__(".byte " REX_PREFIX "0x0f,0xae,0x27"
- : : "D" (&(fpu->state->xsave)),
- "a" (-1), "d"(-1) : "memory");
+ alternative_input(
+ ".byte " REX_PREFIX "0x0f,0xae,0x27",
+ ".byte " REX_PREFIX "0x0f,0xae,0x37",
+ X86_FEATURE_XSAVEOPT,
+ [fx] "D" (&fpu->state->xsave), "a" (-1), "d" (-1) :
+ "memory");
}
#endif
Index: tip-linux-2.6/arch/x86/kernel/cpu/common.c
===================================================================
--- tip-linux-2.6.orig/arch/x86/kernel/cpu/common.c
+++ tip-linux-2.6/arch/x86/kernel/cpu/common.c
@@ -140,10 +140,18 @@ EXPORT_PER_CPU_SYMBOL_GPL(gdt_page);
static int __init x86_xsave_setup(char *s)
{
setup_clear_cpu_cap(X86_FEATURE_XSAVE);
+ setup_clear_cpu_cap(X86_FEATURE_XSAVEOPT);
return 1;
}
__setup("noxsave", x86_xsave_setup);
+static int __init x86_xsaveopt_setup(char *s)
+{
+ setup_clear_cpu_cap(X86_FEATURE_XSAVEOPT);
+ return 1;
+}
+__setup("noxsaveopt", x86_xsaveopt_setup);
+
#ifdef CONFIG_X86_32
static int cachesize_override __cpuinitdata = -1;
static int disable_x86_serial_nr __cpuinitdata = 1;
Index: tip-linux-2.6/arch/x86/include/asm/i387.h
===================================================================
--- tip-linux-2.6.orig/arch/x86/include/asm/i387.h
+++ tip-linux-2.6/arch/x86/include/asm/i387.h
@@ -60,7 +60,7 @@ extern int restore_i387_xstate_ia32(void
static __always_inline __pure bool use_xsaveopt(void)
{
- return 0;
+ return static_cpu_has(X86_FEATURE_XSAVEOPT);
}
static __always_inline __pure bool use_xsave(void)
Index: tip-linux-2.6/arch/x86/kernel/cpu/addon_cpuid_features.c
===================================================================
--- tip-linux-2.6.orig/arch/x86/kernel/cpu/addon_cpuid_features.c
+++ tip-linux-2.6/arch/x86/kernel/cpu/addon_cpuid_features.c
@@ -35,6 +35,7 @@ void __cpuinit init_scattered_cpuid_feat
{ X86_FEATURE_ARAT, CR_EAX, 2, 0x00000006, 0 },
{ X86_FEATURE_APERFMPERF, CR_ECX, 0, 0x00000006, 0 },
{ X86_FEATURE_EPB, CR_ECX, 3, 0x00000006, 0 },
+ { X86_FEATURE_XSAVEOPT, CR_EAX, 0, 0x0000000d, 1 },
{ X86_FEATURE_CPB, CR_EDX, 9, 0x80000007, 0 },
{ X86_FEATURE_NPT, CR_EDX, 0, 0x8000000a, 0 },
{ X86_FEATURE_LBRV, CR_EDX, 1, 0x8000000a, 0 },
next prev parent reply other threads:[~2010-07-19 23:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-19 23:05 [patch 0/5] x86: xsaveopt kernel enabling patches - v2 Suresh Siddha
2010-07-19 23:05 ` [patch 1/5] x86: track the offset, size of features state in the xsave layout Suresh Siddha
2010-07-20 1:51 ` [tip:x86/xsave] x86, xsave: Track the offset, size of " tip-bot for Suresh Siddha
2010-07-19 23:05 ` [patch 2/5] x86: sync xsave memory layout with its header for user handling Suresh Siddha
2010-07-20 1:52 ` [tip:x86/xsave] x86, xsave: Sync " tip-bot for Suresh Siddha
2010-07-19 23:05 ` [patch 3/5] x86: extend init_scattered_cpuid_features() to consider cpuid subleaves Suresh Siddha
2010-07-20 0:51 ` [tip:x86/cpu] x86, cpu: Make init_scattered_cpuid_features() " tip-bot for Suresh Siddha
2010-07-19 23:05 ` [patch 4/5] x86: Add xsaveopt cpufeature Suresh Siddha
2010-07-20 0:52 ` [tip:x86/cpu] x86, cpu: " tip-bot for Suresh Siddha
2010-07-19 23:05 ` Suresh Siddha [this message]
2010-07-20 0:52 ` [tip:x86/cpu] x86, cpu: Enumerate xsaveopt tip-bot for Suresh Siddha
2010-07-20 1:52 ` [tip:x86/xsave] x86, xsave: Use xsaveopt in context-switch path when supported tip-bot for Suresh Siddha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100719230205.604014179@sbs-t61.sc.intel.com \
--to=suresh.b.siddha@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome