mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH] staging: clean up code a bit, use kernel native methods
Date: Thu, 22 Jul 2010 08:15:45 -0700	[thread overview]
Message-ID: <20100722151545.GA6696@suse.de> (raw)
In-Reply-To: <1279805042-9936-1-git-send-email-andy.shevchenko@gmail.com>

On Thu, Jul 22, 2010 at 04:24:02PM +0300, Andy Shevchenko wrote:
> Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Cc: Greg Kroah-Hartman <gregkh@suse.de>
> Cc: devel@driverdev.osuosl.org
> ---
>  drivers/staging/otus/apdbg.c             |   22 -----------------
>  drivers/staging/panel/panel.c            |   19 +++++---------
>  drivers/staging/rtl8192su/r8192S_Efuse.c |   27 ++-------------------
>  drivers/staging/wlags49_h2/wl_util.c     |   37 +-----------------------------
>  drivers/staging/wlags49_h2/wl_util.h     |    2 -
>  drivers/staging/wlan-ng/prism2sta.c      |    6 +---

Can you break this up into 5 different patches, one per driver, and use
a better description of exactly what you did in each driver?

thanks,

greg k-h

  reply	other threads:[~2010-07-22 15:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-22 13:24 Andy Shevchenko
2010-07-22 15:15 ` Greg KH [this message]
2010-07-22 16:57   ` [PATCH 0/5] " Andy Shevchenko
2010-07-22 16:57     ` [PATCH 1/5] staging: remove unused methods Andy Shevchenko
2010-07-22 16:57     ` [PATCH 2/5] staging: panel: change own pieces of code by strtoul() Andy Shevchenko
2010-07-22 16:57     ` [PATCH 3/5] staging: rtl8192su: don't use own isxdigit() method Andy Shevchenko
2010-07-22 16:57     ` [PATCH 4/5] staging: wlags49_h2: remove custom hex_to_bin() method Andy Shevchenko
2010-07-22 16:57     ` [PATCH 5/5] staging: wlan-ng: remove own bin2hex converter Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100722151545.GA6696@suse.de \
    --to=gregkh@suse.de \
    --cc=andy.shevchenko@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome