From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
devel@driverdev.osuosl.org
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: [PATCH 5/5] staging: wlan-ng: remove own bin2hex converter
Date: Thu, 22 Jul 2010 19:57:11 +0300 [thread overview]
Message-ID: <b1b31effdd7ec5692844760f35142d6199b80662.1279817399.git.andy.shevchenko@gmail.com> (raw)
In-Reply-To: <20100722151545.GA6696@suse.de>
In-Reply-To: <cover.1279817399.git.andy.shevchenko@gmail.com>
In kernel we have hex_asc_hi and hex_asc_lo macroses to do the job.
Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
---
drivers/staging/wlan-ng/prism2sta.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/prism2sta.c
index 5ec5741..1a502bc 100644
--- a/drivers/staging/wlan-ng/prism2sta.c
+++ b/drivers/staging/wlan-ng/prism2sta.c
@@ -83,8 +83,6 @@
#include "hfa384x.h"
#include "prism2mgmt.h"
-#define wlan_hexchar(x) (((x) < 0x0a) ? ('0' + (x)) : ('a' + ((x) - 0x0a)))
-
/* Create a string of printable chars from something that might not be */
/* It's recommended that the str be 4*len + 1 bytes long */
#define wlan_mkprintstr(buf, buflen, str, strlen) \
@@ -99,8 +97,8 @@
} else { \
(str)[j] = '\\'; \
(str)[j+1] = 'x'; \
- (str)[j+2] = wlan_hexchar(((buf)[i] & 0xf0) >> 4); \
- (str)[j+3] = wlan_hexchar(((buf)[i] & 0x0f)); \
+ (str)[j+2] = hex_asc_hi((buf)[i]); \
+ (str)[j+3] = hex_asc_lo((buf)[i]); \
j += 4; \
} \
} \
--
1.7.1.1
prev parent reply other threads:[~2010-07-22 16:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-22 13:24 [PATCH] staging: clean up code a bit, use kernel native methods Andy Shevchenko
2010-07-22 15:15 ` Greg KH
2010-07-22 16:57 ` [PATCH 0/5] " Andy Shevchenko
2010-07-22 16:57 ` [PATCH 1/5] staging: remove unused methods Andy Shevchenko
2010-07-22 16:57 ` [PATCH 2/5] staging: panel: change own pieces of code by strtoul() Andy Shevchenko
2010-07-22 16:57 ` [PATCH 3/5] staging: rtl8192su: don't use own isxdigit() method Andy Shevchenko
2010-07-22 16:57 ` [PATCH 4/5] staging: wlags49_h2: remove custom hex_to_bin() method Andy Shevchenko
2010-07-22 16:57 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1b31effdd7ec5692844760f35142d6199b80662.1279817399.git.andy.shevchenko@gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®