* [PATCH 2/2] s6e63m0: fix section mismatch
@ 2010-07-28 3:07 Axel Lin
2010-07-28 22:31 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2010-07-28 3:07 UTC (permalink / raw)
To: linux-kernel; +Cc: Richard Purdie, Andrew Morton, InKi Dae
Eliminate section mismatch warning by marking s6e63m0_probe() as __devinit.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/video/backlight/s6e63m0.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/backlight/s6e63m0.c b/drivers/video/backlight/s6e63m0.c
index b27ccf9..1757379 100644
--- a/drivers/video/backlight/s6e63m0.c
+++ b/drivers/video/backlight/s6e63m0.c
@@ -732,7 +732,7 @@ static ssize_t s6e63m0_sysfs_show_gamma_table(struct device *dev,
static DEVICE_ATTR(gamma_table, 0644,
s6e63m0_sysfs_show_gamma_table, NULL);
-static int __init s6e63m0_probe(struct spi_device *spi)
+static int __devinit s6e63m0_probe(struct spi_device *spi)
{
int ret = 0;
struct s6e63m0 *lcd = NULL;
--
1.5.4.3
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 2/2] s6e63m0: fix section mismatch
2010-07-28 3:07 [PATCH 2/2] s6e63m0: fix section mismatch Axel Lin
@ 2010-07-28 22:31 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2010-07-28 22:31 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Richard Purdie, InKi Dae
On Wed, 28 Jul 2010 11:07:36 +0800
Axel Lin <axel.lin@gmail.com> wrote:
> Eliminate section mismatch warning by marking s6e63m0_probe() as __devinit.
>
Please aways quote the error messages or warnings when fixing build
errors or warnings. It helps with the review quite a lot.
>
> diff --git a/drivers/video/backlight/s6e63m0.c b/drivers/video/backlight/s6e63m0.c
> index b27ccf9..1757379 100644
> --- a/drivers/video/backlight/s6e63m0.c
> +++ b/drivers/video/backlight/s6e63m0.c
> @@ -732,7 +732,7 @@ static ssize_t s6e63m0_sysfs_show_gamma_table(struct device *dev,
> static DEVICE_ATTR(gamma_table, 0644,
> s6e63m0_sysfs_show_gamma_table, NULL);
>
> -static int __init s6e63m0_probe(struct spi_device *spi)
> +static int __devinit s6e63m0_probe(struct spi_device *spi)
> {
> int ret = 0;
> struct s6e63m0 *lcd = NULL;
Many drivers/video/backlight/*.c drivers use __devinit for the
platform_driver.probe handler. Quite a lot use nothing (ie: .text).
Some still use __init. About half of them use __devexit_p for .remove
and half don't. It looks like it all needs a bit of loving care.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-28 22:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-07-28 3:07 [PATCH 2/2] s6e63m0: fix section mismatch Axel Lin
2010-07-28 22:31 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®